Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated FILTER_SANITIZE_STRING #2529

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Replace deprecated FILTER_SANITIZE_STRING #2529

merged 3 commits into from
Mar 28, 2022

Conversation

sjinks
Copy link
Contributor

@sjinks sjinks commented Dec 17, 2021

Description of the Change

This PR replaces the deprecated FILTER_SANITIZE_STRING with other filters, mostly with FILTER_SANITIZE_SPECIAL_CHARS.

It is a copy of Automattic#135, and it has already been tested.

Alternate Designs

N/A

Benefits

  • Better compatibility with PHP 8.1

Possible Drawbacks

N/A

Verification Process

The changes were verified by vip-go-mu-plugin's test suite as described in Automattic/vip-go-mu-plugins#2667; this patch was tested against WP 5.5, 5.6, 5.7, 5.8, trunk; PHP 7.4, PHP 8.0, PHP 8.1

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Fixed: better compatibility with PHP 8.1 by replacing the deprecated FILTER_SANITIZE_STRING.

@felipeelia felipeelia self-assigned this Mar 15, 2022
@felipeelia felipeelia added this to the 4.1.0 milestone Mar 15, 2022
@felipeelia felipeelia merged commit 3c5831c into 10up:develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants