Compatibility with PHP 8.1 #2667
Comments
|
With this "patch": diff --git a/000-vip-init.php b/000-vip-init.php
index 2c132dbc9..0e9f1c8ff 100644
--- a/000-vip-init.php
+++ b/000-vip-init.php
@@ -272,3 +272,4 @@ if ( ! defined( 'WP_RUN_CORE_TESTS' ) || ! WP_RUN_CORE_TESTS ) {
}
do_action( 'vip_loaded' );
+error_reporting( error_reporting() & ~ ( E_DEPRECATED | E_USER_DEPRECATED ) );all tests pass. |
GH-2667: fix 'Implicit conversion from float to int loses precision'
|
This issue has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed. This is an automation to keep issues manageable and actionable and is not a comment on the quality of this issue nor on the work done so far. Closed issues are still valuable to the project and are available to be searched. |
|
This issue has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed. This is an automation to keep issues manageable and actionable and is not a comment on the quality of this issue nor on the work done so far. Closed issues are still valuable to the project and are available to be searched. |
This is an umbrella issue for all PHP 8.1-related bugs.
The goal is to make
vip-go-mu-pluginsfully compatible with PHP 8.1.We use the following commands to run the test suite against PHP 8.1:
So far, the test suite generates 448 errors.
PHP Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /home/circleci/project/000-debug/debug-mode.php on line 29(Fix incompatibilities with PHP 8.1 #2668)PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/circleci/project/vip-helpers/class-user-cleanup.php on line 16(Fix incompatibilities with PHP 8.1 #2668)PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /home/circleci/project/search/includes/classes/class-search.php on line 1902(Fix incompatibilities with PHP 8.1 #2668)PHP Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in /home/circleci/project/vip-helpers/vip-utils.php on line 356(Fix incompatibilities with PHP 8.1 #2668)PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /home/circleci/project/search/includes/classes/class-search.php on line 1537(Fix incompatibilities with PHP 8.1 #2668)PHP Deprecated: Implicit conversion from float 1652683804.007 to int loses precision in /home/circleci/project/tests/config/test-site-details-index.php on line 115(GH-2667: fix 'Implicit conversion from float to int loses precision' #3155)Third-party plugins/dependencies:
Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/circleci/project/vendor/rmccue/requests/library/Requests/Utility/CaseInsensitiveDictionary.php on line 40PHP Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /home/circleci/project/search/elasticpress/includes/classes/Feature/Search/Synonyms.php on line 329Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/circleci/project/vendor/rmccue/requests/library/Requests/Utility/CaseInsensitiveDictionary.php on line 51Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/circleci/project/vendor/rmccue/requests/library/Requests/Utility/CaseInsensitiveDictionary.php on line 68Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/circleci/project/vendor/rmccue/requests/library/Requests/Utility/CaseInsensitiveDictionary.php on line 82Deprecated: Return type of Requests_Utility_CaseInsensitiveDictionary::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/circleci/project/vendor/rmccue/requests/library/Requests/Utility/CaseInsensitiveDictionary.php on line 91Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/circleci/project/vendor/rmccue/requests/library/Requests/Cookie/Jar.php on line 63Deprecated: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/circleci/project/vendor/rmccue/requests/library/Requests/Cookie/Jar.php on line 73Deprecated: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/circleci/project/vendor/rmccue/requests/library/Requests/Cookie/Jar.php on line 89Deprecated: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/circleci/project/vendor/rmccue/requests/library/Requests/Cookie/Jar.php on line 102Deprecated: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/circleci/project/vendor/rmccue/requests/library/Requests/Cookie/Jar.php on line 111PHP Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in /home/circleci/project/vendor/rmccue/requests/library/Requests/Transport/cURL.php on line 345The text was updated successfully, but these errors were encountered: