Fix incompatibilities with PHP 8.1 #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
reviewed
Nov 26, 2021
| // phpcs:ignore WordPress.Security.NonceVerification.Recommended | ||
| $enable = filter_var( $_GET['a8c-debug'] ?? '', FILTER_SANITIZE_STRING ); | ||
| // phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized | ||
| $enable = $_GET['a8c-debug'] ?? ''; |
There was a problem hiding this comment.
Could sanitize_text_field() be used here?
There was a problem hiding this comment.
@GaryJones yes, but we use $enable only to compare its value against two predefined constants, that is why I decided not to waste CPU cycles.
pschoffer
approved these changes
Dec 7, 2021
|
r2055-stacks |
rinatkhaziev
added
[Status] Deployed to production
and removed
[Status] Deployed to staging
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes incompatibilities with PHP 8.1 described in #2667.
Changelog Description
Plugin Updated: VIP Init
Fix incompatibilities with PHP 8.1
Plugin Updated: VIP Search
Fix incompatibilities with PHP 8.1
Plugin Updated: VIP Helpers
Fix incompatibilities with PHP 8.1
Checklist
Please make sure the items below have been covered before requesting a review:
Steps to Test
The CI should pass; PHP 8.1 will still fail.