forked from influxdata/telegraf
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated t128_tank to parse the messages #63
Merged
agrawalkaushik
merged 14 commits into
feature/new-plugins-to-reduce-python-overhead
from
WAN-2496-fix-tank-parser-and-add-user-config-field
Nov 1, 2023
Merged
Updated t128_tank to parse the messages #63
agrawalkaushik
merged 14 commits into
feature/new-plugins-to-reduce-python-overhead
from
WAN-2496-fix-tank-parser-and-add-user-config-field
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WAN-2496 #time 30m
gregschrock
reviewed
Oct 17, 2023
WAN-2496 #time 30m
BenMatase
reviewed
Oct 18, 2023
gregschrock
reviewed
Oct 18, 2023
…-2496-fix-tank-parser-and-add-user-config-field
WAN-2496 #time 20m
BenMatase
approved these changes
Oct 19, 2023
gregschrock
reviewed
Oct 19, 2023
WAN-2496 #time 5m
WAN-2496 #time 5m
gregschrock
approved these changes
Oct 20, 2023
BenMatase
approved these changes
Oct 20, 2023
WAN-2496 #time 15m
gregschrock
requested changes
Oct 23, 2023
WAN-2496 #time 30m
WAN-2496 #time 30m
gregschrock
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add unit tests for this; it should not be hard to test
gregschrock
requested changes
Oct 24, 2023
WAN-2496 #time 1h
gregschrock
requested changes
Oct 25, 2023
WAN-2496 #time 20m
WAN-2496 #time 20m
gregschrock
requested changes
Oct 25, 2023
WAN-2496 #time 15m
gregschrock
requested changes
Oct 27, 2023
WAN-2496 #time 1h
gregschrock
approved these changes
Oct 30, 2023
BenMatase
approved these changes
Oct 31, 2023
gregschrock
added a commit
that referenced
this pull request
Nov 2, 2023
* Sqaushed commits WAN-2321 #time 10m * addressed pr comments and added a testcase WAN-2321 #time 10m * Added a new Telegraf input for LTE (#56) * Added a new Telegraf input for events and session-records (#58) * Updated T128_peer_path Tags (#64) * Updated t128_tank to parse the messages (#63) * added a parser to parse data and send as metrics WAN-2496 #time 30m * added a new config option and updated the logic WAN-2496 #time 30m * addressed more comments and simplified logic WAN-2496 #time 20m * addressed comments WAN-2496 #time 5m * updated the index-file config WAN-2496 #time 5m * fixed an issue with last index not being saved WAN-2496 #time 15m * addressed pr comments WAN-2496 #time 30m * added data precision WAN-2496 #time 30m * addressed more comments WAN-2496 #time 1h * addressed comments and test for lastobserved value WAN-2496 #time 20m * added testcase WAN-2496 #time 20m * addressed comments WAN-2496 #time 15m * Fix timestamp precision adjustments WAN-2496 #time 1h --------- Co-authored-by: Greg Schrock <gschrock@juniper.net> * Update README.md for lte-collector * Update README.md for peer path collector --------- Co-authored-by: Shriyansh Kothari <shriyanshk@juniper.net> Co-authored-by: Kaushik Agrawal <60372242+agrawalkaushik@users.noreply.github.com> Co-authored-by: Shriyansh Kothari <100544034+shriyanshk128T@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converting t128_tank data to relevant fields and tags with the help of an inbuilt parser and added a configurable field.
Testing
1s
timeout to[t128_cpu
collector in plugins](https://github.com/Juniper-SSN/ssn-ssr-plugins/pull/581). The robot branch isrelease/5.6.12
Screengrabs
Config
When Index File is Provided
from specified as end
config
from specified as start
config
from is empty
config
When Index File is not Provided
from specified as end
config
Logged out and Logged in the system to produce the event
from specified as start
config
from is empty
config
Boundary Fault in Index File
from specified as end
config
from specified as start
config
from is empty
config
Index file before and after