Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated T128_peer_path Tags #64

Conversation

shriyanshk128T
Copy link

@shriyanshk128T shriyanshk128T commented Oct 19, 2023

Description

After running the MonitoringAgentCommands Robot, it was identified that there was a shortcoming in the plugin where there was one field that was missing and one field's name was different.

Testing

  • Robot Testing

Data we were sending before this PR and the Data it expects

'peer-path-state,adjacentAddress=172.16.3.2,deviceInterface=11,host=t271-dut1.openstacklocal,networkInterface=intf11,node=test1,routerName=combo2,vlan=0 enabled=true,status="UP" 1697668402000000000\n'
peer-path-state, adjacentHostname=([^\,\s]+), deviceInterface=([^\,\s]+), host=([^\,\s]+), networkInterface=([^\,\s]+), peer-path=([^\,\s]+), peerRouter=([^\,\s]+), vlan=([^\,\s]+), status=([^\,\s]+), enabled=([^\,\s]+)
Verify t128_peer_path file output :: Verify the t128_peer_path con... | PASS |
------------------------------------------------------------------------------
MonitoringAgentCommands :: Verify the Monitoring Agent's basic com... | PASS |

@shriyanshk128T shriyanshk128T changed the title updated t128_peerpath after robot testing updated T128_peer_path Tags Oct 19, 2023
@shriyanshk128T shriyanshk128T changed the title updated T128_peer_path Tags Updated T128_peer_path Tags Oct 19, 2023
plugins/inputs/t128_peer_path/t128_peer_path.go Outdated Show resolved Hide resolved
plugins/inputs/t128_peer_path/t128_peer_path.go Outdated Show resolved Hide resolved
WAN-2503 #time 5m
@shriyanshk128T shriyanshk128T merged commit 2749df6 into feature/new-plugins-to-reduce-python-overhead Oct 20, 2023
1 check passed
@shriyanshk128T shriyanshk128T deleted the WAN-2503-fix-peer-path-input-to-match-some-missing-fields branch October 20, 2023 13:15
gregschrock added a commit that referenced this pull request Nov 2, 2023
* Sqaushed commits

WAN-2321 #time 10m

* addressed pr comments and added a testcase

WAN-2321 #time 10m

* Added a new Telegraf input for LTE (#56)

* Added a new Telegraf input for events and session-records (#58)

* Updated T128_peer_path Tags (#64)

* Updated t128_tank to parse the messages (#63)

* added a parser to parse data and send as metrics

WAN-2496 #time 30m

* added a new config option and updated the logic

WAN-2496 #time 30m

* addressed more comments and simplified logic

WAN-2496 #time 20m

* addressed comments

WAN-2496 #time 5m

* updated the index-file config

WAN-2496 #time 5m

* fixed an issue with last index not being saved

WAN-2496 #time 15m

* addressed pr comments

WAN-2496 #time 30m

* added data precision

WAN-2496 #time 30m

* addressed more comments

WAN-2496 #time 1h

* addressed comments and test for lastobserved value

WAN-2496 #time 20m

* added testcase

WAN-2496 #time 20m

* addressed comments

WAN-2496 #time 15m

* Fix timestamp precision adjustments

WAN-2496 #time 1h

---------

Co-authored-by: Greg Schrock <gschrock@juniper.net>

* Update README.md for lte-collector

* Update README.md for peer path collector

---------

Co-authored-by: Shriyansh Kothari <shriyanshk@juniper.net>
Co-authored-by: Kaushik Agrawal <60372242+agrawalkaushik@users.noreply.github.com>
Co-authored-by: Shriyansh Kothari <100544034+shriyanshk128T@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants