Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes parameter 'P' from Shader::from_vertex_string and Shader::from_fragment_string #301

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Removes parameter 'P' from Shader::from_vertex_string and Shader::from_fragment_string #301

merged 1 commit into from
Nov 17, 2021

Conversation

LiquidityC
Copy link
Contributor

Fixes: #300

@17cupsofcoffee
Copy link
Owner

Wow, this has been broken for two whole years and nobody's noticed 🤦 I think I created these methods by copying the Path versions and forgot to remove the generics. Good spot!

I'm honestly surprised Rust doesn't mark this as an error/warning like it does for unused generics on a struct.

This is technically a breaking change (as you could work around the issue by turbofishing the method with any random type), but I don't think anyone would complain if this was fixed in a patch release, so I'll merge this into main rather than 0.7.

@17cupsofcoffee 17cupsofcoffee merged commit 6736615 into 17cupsofcoffee:main Nov 17, 2021
@17cupsofcoffee
Copy link
Owner

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The moethods Shader::from_vertex_string and Shader::from_fragment_string won't build
2 participants