Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes parameter 'P' from Shader::from_vertex_string and Shader::from_fragment_string #301

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Removes parameter 'P' from Shader::from_vertex_string and Shader::from_fragment_string #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/graphics/shader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ impl Shader {
/// underlying graphics API encounters an error.
/// * [`TetraError::InvalidShader`](crate::TetraError::InvalidShader) will be returned if the
/// shader could not be compiled.
pub fn from_vertex_string<P>(ctx: &mut Context, shader: &str) -> Result<Shader> {
pub fn from_vertex_string(ctx: &mut Context, shader: &str) -> Result<Shader> {
Shader::with_device(&mut ctx.device, shader, DEFAULT_FRAGMENT_SHADER)
}

Expand All @@ -209,7 +209,7 @@ impl Shader {
/// underlying graphics API encounters an error.
/// * [`TetraError::InvalidShader`](crate::TetraError::InvalidShader) will be returned if the
/// shader could not be compiled.
pub fn from_fragment_string<P>(ctx: &mut Context, shader: &str) -> Result<Shader> {
pub fn from_fragment_string(ctx: &mut Context, shader: &str) -> Result<Shader> {
Shader::with_device(&mut ctx.device, DEFAULT_VERTEX_SHADER, shader)
}

Expand Down