Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment.yaml: fix ImagrePullSecrets issue #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

antosimeon
Copy link

Overview

  • Provide a detailed description of the changes, the problem that's being
    addressed and how this is objectively a worthwhile addition to the project.

The ImagePullSecrets section is seen as "unknown" if placed under the container section whenever a value for ImagePullSecrets was provided in the values.yaml file. It has to be nested at the same level of the container section, under the spec section. Like it is it's not possible to use private docker images which requires a secret to be downloaded

Changes

  • List the changes that you made
  • Changed the indentation and position of the ImagePullSecrets sections in the deployment.yaml file

Checklist

The ImagePullSecrets section is seen as "unknown" if placed under the container section whenever a value for ImagePullSecrets was provided in the values.yaml file. It has to be nested at the same level of the container section, under the spec section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant