Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post persist Event will not be fired if using the Orphanage #1

Closed
sheeep opened this issue Mar 14, 2013 · 1 comment
Closed

Post persist Event will not be fired if using the Orphanage #1

sheeep opened this issue Mar 14, 2013 · 1 comment

Comments

@sheeep
Copy link
Contributor

sheeep commented Mar 14, 2013

Currently the only point where the POST_PERSIST Event will be fired is in UploadCotroller::upload(). If you're using an Orphanage you have to manually call the Orphanage::uploadFiles method. In addition, the PostPersistEvent always gets a Request object, which is not really useful when using the Orphanage.

Either create a new Event which will be fired after the files where successfully uploaded by the Orphanage or move the request parameter to an option array, like in PostUploadEvent.

@sheeep
Copy link
Contributor Author

sheeep commented Apr 6, 2013

Currently I don't see any use-case where we need another event being dispatched after calling uploadFiles manually.

@sheeep sheeep closed this as completed Apr 6, 2013
sheeep pushed a commit that referenced this issue Oct 14, 2013
bytehead pushed a commit that referenced this issue Dec 23, 2016
Ordered JavaScript libraries by today's relevance
bytehead pushed a commit that referenced this issue Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant