Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Storage system so using an Orphanage won't lead to redundant code #2

Closed
sheeep opened this issue Mar 14, 2013 · 1 comment
Closed

Refactor the Storage system so using an Orphanage won't lead to redundant code #2

sheeep opened this issue Mar 14, 2013 · 1 comment

Comments

@sheeep
Copy link
Contributor

sheeep commented Mar 14, 2013

Currently both classes implementing StorageInterface and classes implementing OrphanageInterface implement their own access points for uploading and deleting files.
It should be considered to refactor this way so we'd have an abstract parent-class for accessing the filesystem (or orphanage).

Maybe it is possible to inject either the Orphanage or the Gaufrette filesystem depending on the configuration value use_orphanage.

Be sure to also fix #1
@sheeep
Copy link
Contributor Author

sheeep commented Mar 28, 2013

Fixed by #7

@sheeep sheeep closed this as completed Mar 28, 2013
sheeep pushed a commit that referenced this issue Oct 14, 2013
@mitom
Merge pull request #2 from sheeep/release-1.0
9a7ce28 
Raised requirement of symfony/framework-bundle to >=2.2.
@glanes glanes mentioned this issue Feb 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sheeep