-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSPB-317: update msteams device name #476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariotutal
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
alexn29
approved these changes
Jan 5, 2023
Irvandoval
approved these changes
Jan 5, 2023
joristirado
pushed a commit
that referenced
this pull request
Jan 20, 2023
ramandeepromana
added a commit
that referenced
this pull request
Dec 15, 2023
…Feature (#493) * feat: Update references to call failover in template/i18n * feat: Update rendering method for call failover feature * feat: Update call forward references on render * feat: Update call forward save logic * chore: Remove dead call forward references * feat: Add support for telicon as feature state indicator * Register call forwarding as supported feature * Create call forwaring submodule skeleton * MSPB-317: update msteams device name (#476) * Add inline components * Add template for simple strategies * Add options template * Add complex strategies template * Add layout template for call-forwarding * Add template for time listings * Modify en-us.json to add call-forwarding parameters * Add call-forwarding styles * Add call-forwarding logic for the template * Modify en-us.json to add call-forwarding parameters * MSPB-253: Requested changes and fixes Requested change/clean up as well as fixes for better match with mockups * Modify current payload to match current structure * Add number option in translations json * Modify payload to match current requirements * Add Vm box logic * Modify data needed for the templates * Modify templates to match current data structure * Remove logs * Modify temnplate to show options acording to selected data * Update template data accoirding to new payload * Update payload according to new requirements * Update voicemail logic * Update templates according to new payload * Fix Seletive payload * Add matchlist functionality * Fix app not refreshing when on save * Fix voicemail functionality * Adjuss logic to match new templates * Modify templates to match current data * Fix off option not working * Add rules template * Fix voicemail option not working * Added owner_id to matchlist * Deleted the pagination in vm boxes * Fix code to modify current flow to match voicemail * Display only user vmboxes instead of account vmboxes * Modify payload and API call to use POST instead of PATCH * Modify current logic to match new payload * Add a function to cleanup data being sent * Modify current template logic * Modify templates to match current requirements * Fix UI being blocked by user walkthrough * Fix voicemails not working properly * Modfiy rule template to match current needs * Modfiy simple strategy template to match current needs * Modfiy complex strategy template to match current needs * Modfiy to and from labels * Add rules template logic * Add logic that renders matchlist * Add logic for when saving the template * Modify logic for selective rules * Add logic for when user has no existing matchlist / for deleting unused matchlist * Add skip to voicemail function * Modify create matchlist function * Changed name function from userUpdateCallflow to userUpdateVoicemailCallflow * Delete pagination from matchList.list * Modify function patchUserMatchList to deleteUserMatchList * Modify renderRulesListingTemplate to accept custom intervals * Added getUserTemporalRule and createUserTemporalRule * Add selective strategy logic * Modify logic for when loading rules templates * Add fillmisingdays function * Add updateflow function * Add regexfromarray function * Add regexToArray function * Add formatRulesData function * Add transformIntervals function * Add transformFlowIntoRules function * Add functions that complete the logic of selective mode * Fix new match list not being loaded correctly * Fix 409 erros due to an unnecesary api call * Fix custom intervals not showing appropriately * Update skip_module to false when on busy or no_answer * Avoid creating call_forward object when on voicemail * Setting skip_module value accordingly * Modify logic to avoid deleting unnecesary API calls * Capitalize match list name * Remove logs * Add translations * General bug fixing * MSPB-253: Refactor to Remove Selective Staggery, Upgrade UI Logic, and Ensure Backward Compatibility - Removed the selective staggery implementation as it no longer aligns with the revised scope and the approaching QA merge deadline. - Integrated updates to Issac's recent work, focusing on two main aspects: 1. Upgraded UI logic to resolve issues that were causing functionality breakdowns, ensuring stability and alignment with the defined scope/mockups. 2. Adapted the new call_forward object structure while ensuring compatibility with the old/no strategies structure, guaranteeing seamless functionality across different versions. --------- Co-authored-by: Joris Tirado <joris@2600hz.com> Co-authored-by: Mauricio Martínez <mauricio.mart9@gmail.com> Co-authored-by: ramandeepromana <rromana@2600hz.com> Co-authored-by: Ramen Romana <78377672+ramandeepromana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.