MSPB-253: Implement 'Always On, Busy, and No Answer' Call Forwarding Feature #493

Isaac2600Hz · 2023-04-02T10:06:59Z

No description provided.

pcandia · 2023-04-02T23:29:12Z

i18n/en-US.json

+ },
+ "acknowledge": {
+ "title": "Acknowledge Call",
+ "helpText": "Receive a prompt to accept forwarded calls. This prevents voicemails from being associated with the 'Forward To' number."


I wouldn't suggest using single quotes, instead you can do

Suggested change

"helpText": "Receive a prompt to accept forwarded calls. This prevents voicemails from being associated with the 'Forward To' number."

"helpText": "Receive a prompt to accept forwarded calls. This prevents voicemails from being associated with the \"Forward To\" number."

pcandia · 2023-04-02T23:38:26Z

submodules/usersCallForwarding/usersCallForwarding.js

+ layoutTemplate.find('.feature-popup-title').each(function () {
+ var strategy = $(this).data('template');
+
+ if (strategy != 'off' || strategy != 'selective') {


Instead i would do this:

Suggested change

if (strategy != 'off' || strategy != 'selective') {

if (strategy !== 'off' || strategy !== 'selective') {

pcandia

I also have one question, why was the "Call Forwarding" option moved to the left of "Caller-ID number"? In the mockup I see it as the second option, which is how it was before:

Also, when testing the changes I saw a few issues, the first ones are that saving any option causes issues:

Also, I would recommend checking the linter by running gulp lint --app=voip
You can see a bunch of suggestions which some are part of my review, please let me know if you have any issues running this or understanding what its asking you to do, some examples are these:

pcandia · 2023-04-02T23:47:14Z

submodules/usersCallForwarding/usersCallForwarding.js

+ })
+
+ $template.find('.radio-state').on('change', function () {
+ var self = this,


you can remove this line as this is unused.

pcandia · 2023-04-02T23:49:24Z

submodules/usersCallForwarding/usersCallForwarding.js

+
+ if (self.checked && self.defaultValue == 'voicemail') {
+ _.each(options, function (div) {
+ if (div.children[0].innerText != 'Forward direct calls only') {


This is just a suggestion, instead of doing this, maybe you can add a class in the div instead of this.

Suggested change

if (div.children[0].innerText != 'Forward direct calls only') {

if ($divClassName.innerText !== 'Forward direct calls only') {

pcandia · 2023-04-02T23:51:45Z

submodules/usersCallForwarding/usersCallForwarding.js

+ strategy = self.name.split('.')[0],
+ options = $template.find('.option[strategy=' + strategy + ']');
+
+ if (self.checked && self.defaultValue == 'phoneNumber') {


it's always best to use "===" operator to compare the values as it also checks the data type

Suggested change

if (self.checked && self.defaultValue == 'phoneNumber') {

if (self.checked && self.defaultValue === 'phoneNumber') {

pcandia · 2023-04-02T23:52:03Z

submodules/usersCallForwarding/usersCallForwarding.js

+ _.each(options, function (div) {
+ $template.find(div).removeClass('disabled').find('input')
+ })
+ if (strategy == 'selective') {


same here

Suggested change

if (strategy == 'selective') {

if (strategy === 'selective') {

pcandia · 2023-04-02T23:52:26Z

submodules/usersCallForwarding/usersCallForwarding.js

+ }
+ }
+
+ if (self.checked && self.defaultValue == 'voicemail') {


and here

Suggested change

if (self.checked && self.defaultValue == 'voicemail') {

if (self.checked && self.defaultValue === 'voicemail') {

pcandia · 2023-04-03T00:11:56Z

submodules/usersCallForwarding/views/complexStrategy.html

+
+ <div class="remove-rule">
+ <label>
+ Remove rule


pcandia · 2023-04-03T00:12:44Z

submodules/usersCallForwarding/views/complexStrategy.html

+ {{#monsterCheckbox "large-checkbox"}}
+ <input type="checkbox" name="{{strategy}}.isEnabled" {{#if enabled}} checked="checked" {{/if}} />
+ {{/monsterCheckbox}}


Just the spacing here and in other places

Suggested change

{{#monsterCheckbox "large-checkbox"}}

<input type="checkbox" name="{{strategy}}.isEnabled" {{#if enabled}} checked="checked" {{/if}} />

{{/monsterCheckbox}}

{{#monsterCheckbox "large-checkbox"}}

<input type="checkbox" name="{{strategy}}.isEnabled" {{#if enabled}} checked="checked" {{/if}} />

{{/monsterCheckbox}}

pcandia · 2023-04-03T00:14:10Z

submodules/usersCallForwarding/views/listing.html

+ <th>
+ Day
+ </th>
+ <th>
+ Start Time
+ </th>
+ <th>
+ End Time
+ </th>


please do not hardcode values, instead we want to add them to the languages files

pcandia · 2023-04-03T00:14:37Z

submodules/usersCallForwarding/views/options.html

@@ -0,0 +1,24 @@
+<div data-strategy="{{strategy}}">
+ <div class="title">
+ {{@root.i18n.users.callForwarding.strategies.common.options.title}}


Suggested change

{{@root.i18n.users.callForwarding.strategies.common.options.title}}

{{i18n.users.callForwarding.strategies.common.options.title}}

pcandia · 2023-04-03T00:15:05Z

submodules/usersCallForwarding/views/simpleStrategy.html

+
+ <div class="voicemail-wrapper">
+ <div>
+ {{#monsterRadio @root.i18n.users.callForwarding.strategies.common.voicemail.label }}


Suggested change

{{#monsterRadio @root.i18n.users.callForwarding.strategies.common.voicemail.label }}

{{#monsterRadio i18n.users.callForwarding.strategies.common.voicemail.label }}

ramandeepromana · 2023-04-03T12:49:17Z

I also have one question, why was the "Call Forwarding" option moved to the left of "Caller-ID number"? In the mockup I see it as the second option, which is how it was before:

I believe that part was done by @joristirado and @Isaac2600Hz just worked on top of it (if I'm not wrong 😄)

pcandia · 2023-04-03T14:27:32Z

@ramandeepromana yeah, i understand. It's an easy change and also we should always try to follow the mockups. So my comments were based on the mockups https://app.abstract.com/share/1b55ca8e-e43f-429c-969b-22f99f2491bc

Requested change/clean up as well as fixes for better match with mockups

pcandia

Currently when clicking on "custom" the options for it is only displayed in the first option. Also, the "Additional options" are displayed even when it should be displayed for "Phone Number"

And after saving it, only the first row is displayed.

Isaac2600Hz · 2023-09-04T18:26:26Z

Currently when clicking on "custom" the options for it is only displayed in the first option. Also, the "Additional options" are displayed even when it should be displayed for "Phone Number"

And after saving it, only the first row is displayed.

Fixed

submodules/usersCallForwarding/usersCallForwarding.js

…d Ensure Backward Compatibility - Removed the selective staggery implementation as it no longer aligns with the revised scope and the approaching QA merge deadline. - Integrated updates to Issac's recent work, focusing on two main aspects: 1. Upgraded UI logic to resolve issues that were causing functionality breakdowns, ensuring stability and alignment with the defined scope/mockups. 2. Adapted the new call_forward object structure while ensuring compatibility with the old/no strategies structure, guaranteeing seamless functionality across different versions.

pcandia

This looks good to me. Also, after talking to Ramen, he explained to me that the design doesn't need to match the mockups as they are for comm.land, he also said that there won't be additional options for the "voicemail" selection because in Kazoo there is no forward to voicemail and they are manipulating user's default callflow.

…rding Feature Introduced enhancements to the Call Forwarding feature, integrating 'Always On, Busy, and No Answer' modes and changes to Call Failover. 1. Feature Extension: Expanded Call Forwarding functionality to include 'Always On', 'Busy', and 'No Answer'. 2. Decoupled Call Failover: Segregated 'Call Failover' into an independent feature module, for structural clarity in feature configuration and call management. 3. Object Structure Overhaul and Backward Compatibility: Implemented the new `call_forward` object schema and ensured backward compatibility with legacy/no-strategy structures. Please refer original/master branch PR #493 for additional information.

…rding Feature (#523) Introduced enhancements to the Call Forwarding feature, integrating 'Always On, Busy, and No Answer' modes and changes to Call Failover. 1. Feature Extension: Expanded Call Forwarding functionality to include 'Always On', 'Busy', and 'No Answer'. 2. Decoupled Call Failover: Segregated 'Call Failover' into an independent feature module, for structural clarity in feature configuration and call management. 3. Object Structure Overhaul and Backward Compatibility: Implemented the new `call_forward` object schema and ensured backward compatibility with legacy/no-strategy structures. Please refer original/master branch PR #493 for additional information.

Joris Tirado and others added 17 commits December 6, 2022 19:07

feat: Update references to call failover in template/i18n

b6dc3cb

feat: Update rendering method for call failover feature

971166f

feat: Update call forward references on render

4abc218

feat: Update call forward save logic

e42c8ed

chore: Remove dead call forward references

59efbc7

feat: Add support for telicon as feature state indicator

ea10891

Register call forwarding as supported feature

8ed13f3

Create call forwaring submodule skeleton

422ddb0

MSPB-317: update msteams device name (#476)

61b0c6a

Add inline components

5011a06

Add template for simple strategies

65d0f32

Add options template

5ee77a5

Add complex strategies template

f0945be

Add layout template for call-forwarding

0aeed35

Add template for time listings

c359358

Modify en-us.json to add call-forwarding parameters

c9831f1

Add call-forwarding styles

07da9b5

Isaac2600Hz requested a review from pcandia April 2, 2023 10:07

Add call-forwarding logic for the template

efc818e

Isaac2600Hz force-pushed the MSPB-253 branch from b778fd7 to efc818e Compare April 2, 2023 10:09

Isaac2600Hz and others added 3 commits April 2, 2023 04:09

Modify en-us.json to add call-forwarding parameters

70e5c0e

Merge branch 'master' into MSPB-253

454c025

Merge branch 'master' of github.com:2600hz/monster-ui-voip into MSPB-253

524f374

pcandia reviewed Apr 2, 2023

View reviewed changes

pcandia requested changes Apr 3, 2023

View reviewed changes

ramandeepromana assigned Isaac2600Hz Apr 3, 2023

MSPB-253: Requested changes and fixes

8f67f87

Requested change/clean up as well as fixes for better match with mockups

Isaac2600Hz added 5 commits August 30, 2023 01:58

Add transformIntervals function

8f226a4

Add transformFlowIntoRules function

2ba7d98

Add functions that complete the logic of selective mode

3ec8694

Fix new match list not being loaded correctly

cccb3c4

Fix 409 erros due to an unnecesary api call

ae033a9

pcandia requested changes Sep 4, 2023

View reviewed changes

Isaac2600Hz added 2 commits September 4, 2023 12:13

Fix custom intervals not showing appropriately

bb5f870

Update skip_module to false when on busy or no_answer

9658251

pcandia requested review from pcandia and ramandeepromana September 13, 2023 19:19

Isaac2600Hz added 4 commits September 19, 2023 00:41

Avoid creating call_forward object when on voicemail

3e716ed

Setting skip_module value accordingly

5550ea2

Modify logic to avoid deleting unnecesary API calls

8501ff9

Capitalize match list name

f21bc23

ramandeepromana reviewed Sep 26, 2023

View reviewed changes

submodules/usersCallForwarding/usersCallForwarding.js Outdated Show resolved Hide resolved

Isaac2600Hz and others added 4 commits September 26, 2023 12:18

Remove logs

80b041f

Add translations

c30ebc5

General bug fixing

7bb4b29

ramandeepromana self-assigned this Dec 13, 2023

ramandeepromana changed the title ~~MSPB-253: Add call-forwarding app.~~ MSPB-253: Implement 'Always On, Busy, and No Answer' Call Forwarding Feature Dec 13, 2023

pcandia requested a review from ramandeepromana December 14, 2023 22:21

Merge branch 'master' into MSPB-253

dad8d98

pcandia approved these changes Dec 14, 2023

View reviewed changes

ramandeepromana mentioned this pull request Dec 15, 2023

[5.3] MSPB-253: Implement 'Always On, Busy, and No Answer' Call Forwarding Feature #523

Merged

ramandeepromana merged commit c43fbef into master Dec 15, 2023
1 check passed

ramandeepromana deleted the MSPB-253 branch December 15, 2023 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSPB-253: Implement 'Always On, Busy, and No Answer' Call Forwarding Feature #493

MSPB-253: Implement 'Always On, Busy, and No Answer' Call Forwarding Feature #493

Isaac2600Hz commented Apr 2, 2023

pcandia Apr 2, 2023

pcandia Apr 2, 2023

pcandia left a comment •

edited

Loading

pcandia Apr 2, 2023

pcandia Apr 2, 2023

pcandia Apr 2, 2023

pcandia Apr 2, 2023

pcandia Apr 2, 2023

pcandia Apr 3, 2023

pcandia Apr 3, 2023

pcandia Apr 3, 2023

pcandia Apr 3, 2023

pcandia Apr 3, 2023

ramandeepromana commented Apr 3, 2023

pcandia commented Apr 3, 2023

pcandia left a comment •

edited

Loading

Isaac2600Hz commented Sep 4, 2023 •

edited

Loading

pcandia left a comment

	"helpText": "Receive a prompt to accept forwarded calls. This prevents voicemails from being associated with the 'Forward To' number."
	"helpText": "Receive a prompt to accept forwarded calls. This prevents voicemails from being associated with the \"Forward To\" number."

	if (strategy != 'off' \|\| strategy != 'selective') {
	if (strategy !== 'off' \|\| strategy !== 'selective') {

	if (div.children[0].innerText != 'Forward direct calls only') {
	if ($divClassName.innerText !== 'Forward direct calls only') {

	if (self.checked && self.defaultValue == 'phoneNumber') {
	if (self.checked && self.defaultValue === 'phoneNumber') {

	if (strategy == 'selective') {
	if (strategy === 'selective') {

	{{@root.i18n.users.callForwarding.strategies.common.options.title}}
	{{i18n.users.callForwarding.strategies.common.options.title}}

	{{#monsterRadio @root.i18n.users.callForwarding.strategies.common.voicemail.label }}
	{{#monsterRadio i18n.users.callForwarding.strategies.common.voicemail.label }}

MSPB-253: Implement 'Always On, Busy, and No Answer' Call Forwarding Feature #493

MSPB-253: Implement 'Always On, Busy, and No Answer' Call Forwarding Feature #493

Conversation

Isaac2600Hz commented Apr 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pcandia left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ramandeepromana commented Apr 3, 2023

pcandia commented Apr 3, 2023

pcandia left a comment • edited Loading

Choose a reason for hiding this comment

Isaac2600Hz commented Sep 4, 2023 • edited Loading

pcandia left a comment

Choose a reason for hiding this comment

pcandia left a comment •

edited

Loading

pcandia left a comment •

edited

Loading

Isaac2600Hz commented Sep 4, 2023 •

edited

Loading