Fixed Passthrough #1156
Open
Fixed Passthrough #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when two players attacked each other in quick succession, they would both recieve garbage.
This is because internet lag will cause both of them to send the garbage before they recieve it, so no cancellation occurs.
This is the same behavior Tetrio used to have.
I fixed this by storing sent attacks in a list, and attacks now also send the number of attacks their target has sent before them.
This allows me to keep track of which attacks have "crossed" each other, and cancel them out even after they have been sent.
This fix only applies to when 2 players are attacking each other, since in this case the behavior of garbage cancellation is very consistent. In cases where multiple players are attacking different players, the attacks will go past each other as before.