Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github action to deploy app #195

Merged
merged 3 commits into from
Dec 18, 2020
Merged

add github action to deploy app #195

merged 3 commits into from
Dec 18, 2020

Conversation

mohitkyadav
Copy link
Member

@mohitkyadav mohitkyadav commented Dec 18, 2020

Fixes #67

@mohitkyadav
Copy link
Member Author

mohitkyadav commented Dec 18, 2020

@aashutoshrathi how defuq i test this?

😕
https://github.com/2AMDevs/invoicify-app/runs/1574723867?check_suite_focus=true#step:4:80

@aashutoshrathi
Copy link
Contributor

@mohitkyadav we need to set process.env.CI = false

Copy link
Contributor

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should do

mohitkyadav and others added 2 commits December 18, 2020 13:44
Co-authored-by: Aashutosh Rathi <aashutoshrathi@gmail.com>
@aashutoshrathi
Copy link
Contributor

Also, this PR should point to release, right?

Copy link
Contributor

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works!
image

Good Work only4!

@aashutoshrathi
Copy link
Contributor

Take a pull of v0.4.11 and point to the same branch

@mohitkyadav
Copy link
Member Author

@mohitkyadav mohitkyadav changed the base branch from master to v0.4.11 December 18, 2020 08:33
@mohitkyadav
Copy link
Member Author

Take a pull of v0.4.11 and point to the same branch

done @aashutoshrathi

@aashutoshrathi aashutoshrathi merged commit d1c63da into v0.4.11 Dec 18, 2020
@aashutoshrathi aashutoshrathi mentioned this pull request Dec 18, 2020
mohitkyadav added a commit that referenced this pull request Jan 7, 2021
* 🔒 fix: npm audit

* feat: add GitHub action to deploy app (#195) [Fixes #67]

* add GitHub action to deploy the app

* Update .github/workflows/build.yml

* Update build.yml

Co-authored-by: Aashutosh Rathi <aashutoshrathi@gmail.com>

* Break Helper into different services and all (#194)

* init utils.js

* 🔧 utils: Move more utility general function to utils.js

* ✨ add: nodeService, dbService, initializeService

* ✨ feat: Finish breaking helper in services

* ✨ fix: More cleanup

* 📝 docs: Add function docstrings

* 📝 Finish documenting dbService

* ✨ fix: Refer to Download Notification the right way

* 📝 Document Node Service

* Change docstring format

* Fix Build due to missing default entry (#199)

* Allow Alphanumeric Invoice Number and Increments too (#201)

* 📦 feat: Add The Incrementor

* 🐛 fix: Parsing issues

* 💚 bump: Update react-pdf and pdfjs files to remove warnings

* ✨ fix: Made a stable update state to remove lone warning

* add comment of supported format for incrementor

Co-authored-by: Mohit K. Yadav <mohitkyadav@outlook.com>

* 🏁 bump: v0.4.11

Co-authored-by: Mohit Kumar Yadav <mohitkyadav@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants