Fix Build due to missing default entry #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohitkyadav
reviewed
Dec 31, 2020
| @@ -4,7 +4,7 @@ | |||
| "author": "2AM Devs", | |||
| "description": "Digitalizes your billing process", | |||
| "private": true, | |||
| "main": "./public/index.js", | |||
| "main": "./public/electron.js", | |||
There was a problem hiding this comment.
wait that's it we cant rename this file @aashutoshrathi ?
There was a problem hiding this comment.
@mohitkyadav This shouldn't create an issue, but reverting file name works, let's stick to it for the moment,
mohitkyadav
approved these changes
Dec 31, 2020
Merged
mohitkyadav
added a commit
that referenced
this pull request
Jan 7, 2021
* 🔒 fix: npm audit * feat: add GitHub action to deploy app (#195) [Fixes #67] * add GitHub action to deploy the app * Update .github/workflows/build.yml * Update build.yml Co-authored-by: Aashutosh Rathi <aashutoshrathi@gmail.com> * Break Helper into different services and all (#194) * init utils.js * 🔧 utils: Move more utility general function to utils.js * ✨ add: nodeService, dbService, initializeService * ✨ feat: Finish breaking helper in services * ✨ fix: More cleanup * 📝 docs: Add function docstrings * 📝 Finish documenting dbService * ✨ fix: Refer to Download Notification the right way * 📝 Document Node Service * Change docstring format * Fix Build due to missing default entry (#199) * Allow Alphanumeric Invoice Number and Increments too (#201) * 📦 feat: Add The Incrementor * 🐛 fix: Parsing issues * 💚 bump: Update react-pdf and pdfjs files to remove warnings * ✨ fix: Made a stable update state to remove lone warning * add comment of supported format for incrementor Co-authored-by: Mohit K. Yadav <mohitkyadav@outlook.com> * 🏁 bump: v0.4.11 Co-authored-by: Mohit Kumar Yadav <mohitkyadav@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.