Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UToronto to list of running hubs #413

Merged
merged 3 commits into from
May 17, 2021
Merged

Conversation

yuvipanda
Copy link
Member

Ref #175

@yuvipanda yuvipanda requested a review from choldgraf May 15, 2021 15:10
@choldgraf
Copy link
Member

We do keep track of this here: https://team-compass.2i2c.org/en/latest/reference/hubs.html

I imagined that this list was just for the pilot hubs repository, and the list in the team compass would be for all hub infrastructure across repositories. Do you think there's a better way to structure that?

@yuvipanda
Copy link
Member Author

Ah, I didn't know of that one. I'd like them all to be in one place though - mostly as a way to show people 'here is all the hubs we run', regardless of location of repository.

@choldgraf
Copy link
Member

Well yes that was the goal of https://team-compass.2i2c.org/en/latest/reference/hubs.html :-)

It used to have the table from this repository as well, but we moved it here because it was brittle having a table in one repo that used data from another repo.

Another option would be to move everything in that page to the docs for this repo, I just want sure if that would confuse things

@yuvipanda
Copy link
Member Author

Another option would be to move everything in that page to the docs for this repo, I just want sure if that would confuse things

I like that :)

Once #368 is done we'll archive the pangeo-hubs repo as well, so that entry would be gone too.

@choldgraf
Copy link
Member

Ok cool so then I think the order of operations is:

  1. Add the extra hub repos to the list here (we should make clear that those are hosted at a different repo somehow)
  2. Remove from team compass and link to these docs from the TC page

Otherwise updates to the YAML / hardcoded list are
not reflected in the output HTML
@yuvipanda
Copy link
Member Author

Ok, done

image

I don't want to add pangeo-hubs repo here - Farallon is already listed here.

@choldgraf
Copy link
Member

Nice! Do you wanna just leave the Pangeo hubs in the team compass table? I was imagining we'd just remove that table entirely and point here...

@yuvipanda
Copy link
Member Author

Yeah, I was thinking we'll remove that table entirely too. I'll do a PR there later

@choldgraf
Copy link
Member

But then won't we not have any record of the pangeo hubs repo existing? Or do you plan to delete that super quickly?

@yuvipanda
Copy link
Member Author

@choldgraf yeah, no new work can happen there now anyway. I'm tempted to archive it already...

yuvipanda added a commit to yuvipanda/team-compass that referenced this pull request May 15, 2021
- U Toronto hub is listed in 2i2c-org/infrastructure#413
- The pangeo-hubs repo is defunct, hasn't been actively used in a
  while and will be eliminated soon
@yuvipanda
Copy link
Member Author

@choldgraf I opened 2i2c-org/team-compass#103, but also left a comment there about utoronto hub

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Copy link
Contributor

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging now.

@damianavila damianavila merged commit 8d61a4f into 2i2c-org:master May 17, 2021
@choldgraf choldgraf mentioned this pull request Aug 26, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants