Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to pilot-hubs repo for list of hubs #103

Merged
merged 4 commits into from
Jun 29, 2021

Conversation

yuvipanda
Copy link
Member

- U Toronto hub is listed in 2i2c-org/infrastructure#413
- The pangeo-hubs repo is defunct, hasn't been actively used in a
  while and will be eliminated soon
@yuvipanda
Copy link
Member Author

Where do we track deliverables for the UToronto hub? Right now, nowhere!

IMO, we should consider moving that hub into our pilot hubs repo as well. It was the first hub we setup, so it got its own repo. Now maybe we should move it back here. Will make life simpler for us.

@@ -56,7 +56,6 @@ Contains information about the 2i2c team and our projects, and some useful resou
:maxdepth: 1
:caption: Team Reference
reference/projects
reference/hubs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imagined that we would leave this page, but just point it to the pilot hubs repo. That way the source of truth is still the team compass, it just delegates to pilot hubs. Maybe we can just add a section to the "team coordination" page?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just add a section to the "team coordination" page?

Can you expand on that a little?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that if we think it is a bit much to have a dedicated page that simply links to the hubs table in this repo, we could turn that page into a short section here https://team-compass.2i2c.org/en/latest/practices/coordination.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@choldgraf that makes sense - let's do that!

@choldgraf
Copy link
Member

@yuvipanda is this ready to go?

@damianavila
Copy link
Contributor

I am not @yuvipanda 😉 but if we are removing the Hubs page here, we need to make an explicit link/reference to the table living in the pilots-hubs docs. @choldgraf you proposed to put the reference on the coordination page... I think it actually belongs to the https://team-compass.2i2c.org/en/latest/managed-hubs/about.html page, IMHO.

@choldgraf
Copy link
Member

Good point @damianavila - I've added a reference to that page in our about page that you linked above. Also resolved the conflict on index so I think we're ready to go unless anybody objects

@damianavila
Copy link
Contributor

@choldgraf, I do not actually see the reference you said you added when I look at the docs generated from this PR: https://2i2c-team-compass--103.org.readthedocs.build/en/103/managed-hubs/about.html.
Btw, the last commit is also a little bit weird... are you sure you pushed the change you were intended to push?

@choldgraf
Copy link
Member

choldgraf commented Jun 28, 2021

Ermmm yep you're right, will look into it when I'm back at computer

@choldgraf
Copy link
Member

OK updated the PR! It didn't push properly when I tried earlier, thanks for catching it @damianavila :-)

Copy link
Contributor

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@choldgraf choldgraf merged commit 69ac10e into 2i2c-org:main Jun 29, 2021
@choldgraf
Copy link
Member

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants