Remove support for more than 1 domain per hub #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple domains were supported primarily to make sure hubs are reachable by both datahub.mills.edu and mills.cloudbank.2i2c.cloud. In practice, nobody uses the second URL, and this just confuses the deployer code. datahub.mills.edu is a CNAME to mills.cloudbank.2i2c.cloud - but that doesn't require the latter to actually serve any content (over HTTP). CNAME is a DNS feature, so we don't actually have to do anything wrt HTTP serving. Includes slight refactoring to make auth.KeyProvider a little more agnostic to just using with JupyterHubs - could perhaps be used with 2i2c-org#456 in providing OAuth credentials for grafana too
yuvipanda
requested review from
GeorgianaElena and
consideRatio
and removed request for
GeorgianaElena
|
Ping to @GeorgianaElena since she worked on this first. Ping to @consideRatio since we talked about this during a video call yesterday |
damianavila
reviewed
Jun 9, 2021
damianavila
approved these changes
Jun 9, 2021
yuvipanda
commented
Jun 10, 2021
|
Thanks, @damianavila! |
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Jun 10, 2021
- Follow-up to 2i2c-org#458 - domain can not be list anymore with 2i2c-org#460 - Support components config for each cluster is also now present in the cluster.yaml config files, with 2i2c-org#456. Even though that has not been merged yet, it is already deployed. This PR updates the schema to allow the support config.
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Jun 21, 2021
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Jul 6, 2021
This is no longer supported - one hub should just stay in one domain. Ref 2i2c-org#460
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple domains were supported primarily to make sure hubs
are reachable by both datahub.mills.edu and mills.cloudbank.2i2c.cloud.
In practice, nobody uses the second URL, and this just confuses
the deployer code. datahub.mills.edu is a CNAME to
mills.cloudbank.2i2c.cloud - but that doesn't require the latter
to actually serve any content (over HTTP). CNAME is a DNS feature,
so we don't actually have to do anything wrt HTTP serving.
Includes slight refactoring to make auth.KeyProvider a little more
agnostic to just using with JupyterHubs - could perhaps be used
with #456 in providing
OAuth credentials for grafana too