Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Don't mention multiple domains #496

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

yuvipanda
Copy link
Member

This is no longer supported - one hub should just stay in
one domain.

Ref #460

This is no longer supported - one hub should just stay in
one domain.

Ref 2i2c-org#460
@sgibson91
Copy link
Member

So just to make sure I've followed the discussion in #460 - So long as the CNAME is applied in the DNS settings, we don't have to do anything in the hub config for redirection? But users can still use a domain name that doesn't explicitly mention 2i2c to reach a 2i2c managed hub?

I'm thinking about the Pangeo case, if that helps add context to my thought process :)

@yuvipanda
Copy link
Member Author

yuvipanda commented Jul 6, 2021

So just to make sure I've followed the discussion in #460 - So long as the CNAME is applied in the DNS settings, we don't have to do anything in the hub config for redirection?

Yep, that is correct! Ultimately what is needed is for DNS to be able to route from any domain to our cluster, our setup doesn't need to know how.

Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop! 🎉

@yuvipanda yuvipanda merged commit 5ee5ccb into 2i2c-org:master Jul 6, 2021
@yuvipanda
Copy link
Member Author

Thanks, @sgibson91!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants