Redirect test output when we are running on the CI #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were redirecting the test output to prevent the leakage of secrets when running the deployer on the CI. At the same time, the redirection was preventing us to get details about the failure at the time to run the deployer locally. So, the idea of this PR is just redirecting to dev/null only if we are running the deployer on the CI and get the full output when running locally.
|
Picked some reviewers but everyone is invited to review 😉 |
choldgraf
reviewed
Sep 25, 2021
Co-authored-by: Chris Holdgraf <choldgraf@berkeley.edu>
sgibson91
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR is just redirecting to dev/null only if we are running the deployer on the CI and get the full
output when running locally.
Accordingly, to GitHub docs about environment variables, the
CIis always set totrue. I think that should be enough to "detect" the CI environment.Closes #694