Merge pull request #252 from 2pisoftware/feat/remove-inbox

Remove Inbox module and references

system/modules/admin/install/migrations/20240218223900-InboxRemoveTable.php

@@ -0,0 +1,26 @@
+<?php
+/**
+ * Removes the inbox table from the Inbox module that is no longer used or supported.
+ */
+
+class InboxRemoveTable extends CmfiveMigration
+{
+    public function up(): void
+    {
+        //Drop the tables
+        $this->dropTable('inbox');
+        $this->dropTable('inbox_message');
+
+        //Clear out the related user roles
+        $this->w->db->delete('user_role')->where('role', 'inbox_sender')->execute();
+        $this->w->db->delete('user_role')->where('role', 'inbox_reader')->execute();
+    }
+
+    public function down(): void
+    {
+    }
+
+    public function description() {
+        return 'Remove inbox table and roles';
+    }
+}

system/modules/admin/models/NotificationService.php

@@ -3,7 +3,6 @@
 class NotificationService extends DbService
 {
     const TYPE_EMAIL = 'email';
-    const TYPE_INBOX = 'inbox';
 
     /**
      * Sends a notification to a user
@@ -36,12 +35,6 @@ public function send(string $subject, string $module, string $template_name, Use
             $output = TemplateService::getInstance($this->w)->render($template, $template_data);
 
             switch ($method) {
-                case NotificationService::TYPE_INBOX:
-                    if (Config::get('inbox.active') === true) {
-                        InboxService::getInstance($this->w)->addMessage($subject, $output, $recipient_user->id, null, null, false);
-                    }
-                    break;
-
                 case NotificationService::TYPE_EMAIL:
                 default:
                     MailService::getInstance($this->w)->sendMail(
@@ -126,8 +119,7 @@ public function getUserPreferences(User $user)
     public function getAvailableNotificationMethods()
     {
         return [
-            NotificationService::TYPE_EMAIL,
-            NotificationService::TYPE_INBOX
+            NotificationService::TYPE_EMAIL
         ];
     }
 }