Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Inbox module and references #252

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Remove Inbox module and references #252

merged 4 commits into from
Feb 19, 2024

Conversation

mattbell87
Copy link
Member

@mattbell87 mattbell87 commented Feb 5, 2024

Delete the inbox module

  • Remove module
  • Remove notification type
  • Migrations

@mattbell87
Copy link
Member Author

Playwright tests seem to pass in CI, but several fail codespaces through vscode or in the terminal, mostly timeout related I think (the 5000ms).

Copy link
Contributor

@adam-buckley adam-buckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

@mattbell87
Copy link
Member Author

Hey @adam-buckley I may need some help with the migration. Its not a complicated migration, but I've tried a couple of things and php cmfive.php install migrations doesn't remove an inbox table if it exists.

I've tried these but I think I may be off the path a bit:

  • Adding an SQL file to the install/updates directory. Is this dir still used?
  • Adding a migration PHP file to the admin module migrations. Also is this the correct place to put a migration for the inbox module, or is there a more generic place?

Cheers

@mattbell87 mattbell87 marked this pull request as ready for review February 18, 2024 23:50
@mattbell87 mattbell87 merged commit 38ba32f into develop Feb 19, 2024
11 checks passed
@chris-bateman chris-bateman mentioned this pull request Feb 20, 2024
32 tasks
@mattbell87 mattbell87 deleted the feat/remove-inbox branch February 20, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants