Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terrain tiles: limit memory use #25

Open
Ylannl opened this issue Nov 1, 2020 · 2 comments
Open

Terrain tiles: limit memory use #25

Ylannl opened this issue Nov 1, 2020 · 2 comments

Comments

@Ylannl
Copy link
Member

Ylannl commented Nov 1, 2020

We should limit the maximum size for the activeTiles variable in TilesRenderer.js. It can get pretty big now if you keep panning in the same matrix level.
@Ylannl Ylannl changed the title Limit memory use of terrain tiles Rerrain tiles: limit memory use Nov 1, 2020
@Ylannl Ylannl changed the title Rerrain tiles: limit memory use Terrain tiles: limit memory use Nov 1, 2020
@Ylannl
Copy link
Member Author

Ylannl commented Dec 1, 2020

this seems to be less of an issue since #20 was merged

jliempt added a commit that referenced this issue Oct 8, 2021
@jliempt
Dispose tiles not in view anymore (helps with #25), alter tileMatrix …
f67a3ec 
…level change cleanup
@jliempt
Copy link
Contributor

jliempt commented Nov 15, 2021

Terrain tiles were not being disposed properly. This has been addressed in the feature/colormap branch, and using a Three.js browser-plugin shows that there are now less objects in the scene. But haven't profiled if the whole issue is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ylannl @jliempt