Cecil. Meta library. Incorrect default values

[3F]

whoops... current default values are not correct for DllExportAttribute, because today this used only with CustomAttribute -> ConstructorArguments

just noticed -_-

i.e. all below will not work (usage to initialize):

public DllExportAttribute(string function)
    : this(function, CallingConvention.Cdecl)
{
    ...
}

...

public CallingConvention CallingConvention
{
    get;
    set;
} = CallingConvention.Cdecl;

....

public DllExportAttribute()
{
    CallingConvention = CallingConvention.Cdecl;
}

etc.

ok, I'll fix it coming soon

[3F]

  IL_0001:  ldarg.0
  IL_0002:  ldc.i4.2
  IL_0003:  call      
----
    IL_0000:  ldarg.0
    IL_0001:  ldc.i4.2
    IL_0002:  stfld    

samples:

.method public hidebysig instance void  Init() cil managed
{
  // Code size       10 (0xa)
  .maxstack  8
  IL_0000:  nop
  IL_0001:  ldarg.0
  IL_0002:  ldc.i4.2
  IL_0003:  call       instance void D3F00FF1770DED978EC774BA389F2DC901F4.B00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000.C00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000.D00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000.E00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000.F00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000.DllExportAttribute::set_CallingConvention(valuetype [mscorlib]System.Runtime.InteropServices.CallingConvention)
  IL_0008:  nop
  IL_0009:  ret
}

.field private valuetype ['mscorlib']'System.Runtime.InteropServices'.'CallingConvention' '<CallingConvention>k__BackingField'

.method public hidebysig specialname instance valuetype ['mscorlib']'System.Runtime.InteropServices'.'CallingConvention' 
        'get_CallingConvention'() cil managed
{
  .custom instance void ['mscorlib']'System.Runtime.CompilerServices'.'CompilerGeneratedAttribute'::.ctor() = ( 01 00 00 00 ) 
  // Code size       7 (0x7)
  .maxstack  8
  IL_0000:  ldarg.0
  IL_0001:  ldfld      valuetype ['mscorlib']'System.Runtime.InteropServices'.'CallingConvention' 'TestForDllExport'.'DllExportAttribute'::'<CallingConvention>k__BackingField'
  IL_0006:  ret
}

.method public hidebysig specialname rtspecialname 
        instance void  .ctor() cil managed
{
  // Code size       16 (0x10)
  .maxstack  8
  IL_0000:  ldarg.0
  IL_0001:  ldc.i4.2
  IL_0002:  stfld      valuetype ['mscorlib']'System.Runtime.InteropServices'.'CallingConvention' 'TestForDllExport'.'DllExportAttribute'::'<CallingConvention>k__BackingField'
  IL_0007:  ldarg.0
  IL_0008:  call       instance void ['mscorlib']'System'.'Attribute'::.ctor()
  IL_000d:  nop
  IL_000e:  nop
  IL_000f:  ret
}

[3F]

.ctor above is more clear. Now, to set values by default inside metalib:

public CallingConvention CallingConvention
{
    get;
    set;
} = CallingConvention.Cdecl;

https://github.com/3F/DllExport/blob/master/Metadata/DllExportAttribute.cs