Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-English system language - syntax error #7

Closed
den-run-ai opened this issue Sep 5, 2016 · 3 comments
Closed

non-English system language - syntax error #7

den-run-ai opened this issue Sep 5, 2016 · 3 comments
Labels
origin
Milestone
v1.4

Comments

@den-run-ai
Copy link

pythonnet/pythonnet#220

the issue is:

syntax error at token '.field' in: .field static assembly initonly int64

and the manual solution is:

yajiedesign commented 3 days ago
ok,I found and fixed the problem.
RGiesecke.DllExport does not support non English ILdasm generated IL file.
you can pathed RGiesecke.DllExport with ilspy fixed it
find and change "// Code" to you system language.
it in RGiesecke.DllExport.Parsing.Actions.DeleteExportAttributeParserAction.Execute
@3F 3F added the origin label Sep 5, 2016
@3F
Copy link
Owner

3F commented Sep 5, 2016

Please use pull request, because I can't reproduce this problem. I'll consider it later if you already have fixes

Are you sure that's problem with // Code comment line ? this debugged at runtime ?

Can I see .il instructions when it fail ?

to get it manually, use for example:

ildasm /quoteallnames /unicode /nobar /linenum "/out:lib.il" "lib.dll"

@den-run-ai den-run-ai mentioned this issue Sep 6, 2016
Closed
@3F
Copy link
Owner

3F commented Oct 4, 2016 •
edited
Loading

can you check ca1d73a with problem locale ? (see binaries from nightly builds)
probably it was solved along with latest changes ( bug #10 )

if not - please details

https://ci.appveyor.com/api/buildjobs/921ni147kejg219v/artifacts/bin%2FRelease%2FDllExport.1.3.0.nupkg

@3F 3F added this to the v1.4 milestone Oct 4, 2016
3F added a commit that referenced this issue Oct 5, 2016
@3F
public release v1.4
c637152 
    * FIXED: Fixed bug - `An item with the same key has already been added`. Issue #10
    * FIXED: Bug with Meta library: Incorrect default values. Issue #16
             please note, the __cdecl is the default calling convention for our library
             as and for C and C++ programs.

    * FIXED?: Probably fixed bug - `Script errors on package install` Issue #6
    * FIXED?: Probably fixed bug - `non-English system language - syntax error` Issue #7
    * NEW: GUI Configurator with updated ddNS features.
    * NEW: Implemented feature 'Export for platform': [ x86 / x64 / x86 + x64 ] Issue #9
    * NEW: Implemented feature 'Base for ordinals'. Issue #11
           There is also alternative to configure this number - MSBuild property: DllExportOrdinalsBase

    * NEW: The one (1) now is used by default as Base for all ordinals.
           `Mimic ordinal counter (start from 1 instead of 0)` Issue #8

    * CHANGED: The ddNS features now as binary cmdlet `NSBin`. Use `nsbin.bat` if needed.
    * CHANGED: `Set "Inherited = false" in AttributeUsage for DllExportAttribute`. Issue #15
    * OTHER: other possible changes and fixes.
@3F
Copy link
Owner

3F commented Oct 5, 2016

v1.4 changelog entry:

    * FIXED?: Probably fixed bug - `non-English system language - syntax error` Issue #7

reopen if needed

@3F 3F closed this as completed Oct 5, 2016
@den-run-ai den-run-ai mentioned this issue Feb 8, 2017
Closed
@den-run-ai den-run-ai mentioned this issue Apr 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
origin
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
2 participants
@3F @den-run-ai