Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCIe initialization #106

Merged
merged 16 commits into from
Oct 22, 2021
Merged

PCIe initialization #106

merged 16 commits into from
Oct 22, 2021

Conversation

SergiiDmytruk
Copy link
Member

Includes:

  • istep 10.10
  • istep 10.12
  • new, more full, implementation of istep 14.3 (includes istep 14.5 in Hostboot and here)

istep 14.3 gets stuck on first SCOM read for the first PEC.

krystian-hebel
krystian-hebel requested changes Oct 21, 2021
View reviewed changes
Copy link
Member

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change. Code works and no longer hangs on retraining during fast reboot path.

src/soc/ibm/power9/romstage.c Outdated Show resolved Hide resolved
krystian-hebel
krystian-hebel requested changes Oct 21, 2021
View reviewed changes
Copy link
Member

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And two more changes from CI

src/soc/ibm/power9/istep_14_3.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/istep_14_3.c Outdated Show resolved Hide resolved
krystian-hebel
krystian-hebel requested changes Oct 21, 2021
View reviewed changes
Copy link
Member

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that was more than one change...

src/soc/ibm/power9/istep_14_3.c Outdated Show resolved Hide resolved
@macpijan
Copy link
Member

@SergiiDmytruk Please also rebase on the latest target branch, as we have marged some pieces today. Thanks!

@SergiiDmytruk
Start with PCI initialization
bc79906 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Phase 1 of initialization
e5fe391 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Reorganize code a bit
63f8408 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Enable RI/DI for PCIe
a0c453b 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
First half of Phase2 (PEC init)
4cdcab7 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Second half of Phase2 (PHB init)
66980e8 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Reorganize code into isteps in romstage
f67f7de 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Remove bad check for dying
48545ed 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Small code improvements
86c7ea5 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Fixes for istep 10.10
951aa96 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Non-functional code improvements
5766d92 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Use udelay() where appropriate
544a020 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Fixes for istep 14.3
2d03fc5 
* Small changes for consistency.
* Access some registers through a nest chiplet ID.
* Fix a bug in PEC initialization (ATTR_PROC_PCIE_CACHE_INJ_MODE).

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Fix value of MBOX_SCRATCH_REG6_GROUP_PUMP_MODE
2a2e5b2 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Remove non-breaking spaces in istep_14_3.c
0c6ccde 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Invoke istep_10_* earlier in romstage
16ed247 
Change-Id: I229f3b40d1f8b115eaa1d9d9b9e813a43ee807ae
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@krystian-hebel krystian-hebel merged commit ce64c09 into 3mdeb:talos_2_support_payload Oct 22, 2021
@SergiiDmytruk SergiiDmytruk deleted the pci_initialization branch October 22, 2021 11:42
@tlaurion tlaurion mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystian-hebel krystian-hebel krystian-hebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergiiDmytruk @macpijan @krystian-hebel