Fix reporting only 50% of calls to 3scale backend [THREESCALE-1080] #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
changed the title
davidor
reviewed
Jun 19, 2018
t/apicast-oidc.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 2: Report calls to 3scale backend |
There was a problem hiding this comment.
I think this test is doing the same as the one above but making 2 requests instead of one
There was a problem hiding this comment.
Exactly. I wanted it to be super obvious. Not sure if setting repeat_each(2) would be obvious enough.
There was a problem hiding this comment.
In that case I would add a comment. Figuring out why this is being tested twice can be difficult without having some context like the PR title.
mikz
force-pushed
the
oidc-reporting
branch
4 times, most recently
from
2031991
to
3392d3c
Compare
mikz
changed the title
davidor
approved these changes
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in credentials juggling APIcast would send raw JWT to 3scale backend instead of just app_id.
That token is of course not understood and the reporting call rejected.
The fix changes how credentials are moved around to reduce risk of future issues.
Fixes THREESCALE-1080
@3scale/qe you might want to incorporate some tests that test metrics reporting accuracy to catch this kind of issues.