Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irc: add support for stateless bridging via draft/relaymsg #1339

Merged
merged 5 commits into from
Dec 30, 2020
Merged

irc: add support for stateless bridging via draft/relaymsg #1339

merged 5 commits into from
Dec 30, 2020

Conversation

jlu5
Copy link
Contributor

@jlu5 jlu5 commented Dec 20, 2020

As discussed at #667 (comment)

@jlu5 jlu5 mentioned this pull request Dec 20, 2020
Merged
@poVoq
Copy link

poVoq commented Dec 24, 2020

This is meant to work with the Oragono IRC server, right?

@jlu5
Copy link
Contributor Author

jlu5 commented Dec 24, 2020

@poVoq This will work with Oragono as well as InspIRCd with a contrib module. (Of course, other server implementations would be welcome too)

42wim
42wim reviewed Dec 29, 2020
View reviewed changes
Copy link
Owner

@42wim 42wim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the suggested //nolint's to disable the error checking, but please run the gofmt -s as suggested by the linter.

bridge/irc/irc.go Show resolved Hide resolved
bridge/irc/irc.go Outdated Show resolved Hide resolved
bridge/irc/irc.go Outdated Show resolved Hide resolved
@42wim
Copy link
Owner

42wim commented Dec 29, 2020

Thanks for this PR!
Could you also include UseRelayMsg in the matterbridge.toml.sample file?

@codeclimate
Copy link

codeclimate bot commented Dec 29, 2020

Code Climate has analyzed commit a1e0de8 and detected 0 issues on this pull request.

View more on Code Climate.

@42wim 42wim added this to the 1.21.0 milestone Dec 30, 2020
@42wim 42wim merged commit a9f89db into 42wim:master Dec 30, 2020
@42wim
Copy link
Owner

42wim commented Dec 30, 2020

Thanks!

@42wim 42wim added the irc label Dec 31, 2020
@qaisjp qaisjp mentioned this pull request Apr 16, 2021
Open
@poVoq poVoq mentioned this pull request Jun 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42wim 42wim 42wim left review comments

Assignees
No one assigned
Labels
irc
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jlu5 @poVoq @42wim