Changes for Usability #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgruss
commented
Jul 14, 2020
dgruss
commented
- Changed MsgUser() to take a message type: Messages now use irc.NOTICE / irc.ERROR unless they are irc.PRIVMSG to be closer to a regular IRC server, creating a more smooth user experience
- Message Playback is disabled for anything older than 24h (fixes I am constantly recieving old backlog #245 for me)
- Take messages to "nickserv" for authentication as well
- If message could not be sent, retry once per second until it works (fixed a bug for me where sent messages never arrived in mattermost)
alexmurray
reviewed
Jul 14, 2020
mm-go-irckit/mmuser.go
Outdated
| @@ -237,11 +237,13 @@ func (u *User) addUserToChannelWorker(channels <-chan *model.Channel, throttle < | |||
| for _, post := range strings.Split(p.Message, "\n") { | |||
| if user, ok := u.mc.Users[p.UserId]; ok { | |||
| date := ts.Format("2006-01-02") | |||
| if ((time.Now()-ts)/int64(time.Millisecond)) < 86400 { | |||
There was a problem hiding this comment.
This seems a bit arbitrary - would it be possible to make this configurable?
There was a problem hiding this comment.
This should be configurable for sure.
If this fixes linked issue (#245) I am pretty sure that it's actually more like side effect than proper fix.
42wim
reviewed
Aug 2, 2020
| u.MsgUser(toUser, "login OK") | ||
| if u.Credentials != nil && u.Token != "" { | ||
| u.MsgUser(toUser, "token used: "+u.Token) | ||
| } |
There was a problem hiding this comment.
I would like to keep those messages, what is your reasoning to remove those?
There was a problem hiding this comment.
I removed the login OK since there is an automatic disconnect from the server now anyways if the login is not OK.
lines 88-90 I'm not sure anymore, might have been an accident...
|
I fully agree ;)
|
|
Are you willing to rebase this ? :/ |
|
closing as no response and outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.