Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am constantly recieving old backlog #245

Closed
lazyusername opened this issue Apr 14, 2019 · 4 comments
Closed

I am constantly recieving old backlog #245

lazyusername opened this issue Apr 14, 2019 · 4 comments

Comments

@lazyusername
Copy link

lazyusername commented Apr 14, 2019

Since update of mattermost to last version (5.9.0) I am recieving old backlog in my irc client. Even when I stop running of matterircd and spawn the process again and then connect with my irc client to matterircd I am recieving backlog in channels that I have already read multiple times.

Example:

[05:09:49] [matterircd]: Replaying since 2019-04-12
[05:09:49] [A]: [12:40] A_text
[05:09:49] [B]: [12:45] B_text
[05:09:49] [C]: [14:38] C_text
[06:47:15] [matterircd]: Replaying since 2019-04-12
[06:47:15] [A]: [12:40] A_text
[06:47:15] [B]: [12:45] B_text
[06:47:15] [C]: [14:38] C_text

Matterircd version: 0.19.2

@42wim
Copy link
Owner

42wim commented Apr 20, 2019

If you didn't enable DisableAutoView = true in your matterircd.toml then this is most likely a bug in mattermost.
We ask mattermost about when you lastviewed a channel, could be something wrong in the database.

@lazyusername
Copy link
Author

lazyusername commented Apr 21, 2019

I didn't set DisableAutoView in my config at all.

@muesli
Copy link
Contributor

muesli commented May 20, 2020

I can reproduce this here, as well. I've now enabled DisableAutoView and will see how that behaves / feels like.

@42wim
Copy link
Owner

42wim commented Aug 16, 2020

I've also got bitten by this and did some further debugging. This is definitely a mattermost issue, they don't update the channel even though we send this event (and we don't receive an error).

To fix this you can just drop a message in the channel that's replaying it and delete the message again.
The issue should be solved.

@42wim 42wim closed this as completed Aug 16, 2020
hloeung added a commit to hloeung/matterircd that referenced this issue Dec 12, 2020
Per 42wim#245, we can't trust
that Mattermost has updated the last viewed for channel. Instead, we
save this locally and use that for replaying of logs. Useful for when
experiencing flaky network causing matterircd to reconnect.
42wim pushed a commit that referenced this issue Dec 18, 2020
* Fixed logging in with personal access token

* Save last viewed at state and use for replaying logs

Per #245, we can't trust
that Mattermost has updated the last viewed for channel. Instead, we
save this locally and use that for replaying of logs. Useful for when
experiencing flaky network causing matterircd to reconnect.

* Fixed using defer in range loops

* Also make the map
hloeung added a commit to hloeung/matterircd that referenced this issue Apr 8, 2021
This partially reverts commit 3a0d0b3. We can't trust that Mattermost
has updated the last viewed for channel which is why we store the
LastViewedAt internally (see PR#361 and 42wim#245).
hloeung added a commit to hloeung/matterircd that referenced this issue Apr 8, 2021
This partially reverts commit 3a0d0b3. We can't trust that Mattermost
has updated the last viewed for channel which is why we store the
LastViewedAt internally (see PR#361 and 42wim#245).
hloeung added a commit to hloeung/matterircd that referenced this issue Apr 8, 2021
This partially reverts commit 3a0d0b3. We can't trust that Mattermost
has updated the last viewed for channel which is why we store the
LastViewedAt internally (see PR#361 and 42wim#245).
hloeung added a commit to hloeung/matterircd that referenced this issue Apr 8, 2021
This partially reverts commit 3a0d0b3. We can't trust that Mattermost
has updated the last viewed for channel which is why we store the
LastViewedAt internally (see PR#361 and 42wim#245).
hloeung added a commit to hloeung/matterircd that referenced this issue Apr 8, 2021
This partially reverts commit 3a0d0b3. We can't trust that Mattermost
has updated the last viewed for channel which is why we store the
LastViewedAt internally (see PR#361 and 42wim#245).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants