Always use stored last viewed at if present #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
cleanup
branch
3 times, most recently
from
83659db to
54f6dc9
Compare
|
Marking it as draft for now. Need to think more about it. |
|
Right, the issue was not trusting Mattermost updating the server side LastViewedAt so we'll see multiple replays of the same msgs. Closing this off as it's not an issue then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 3a0d0b3. We can't trust that Mattermost has updated the last viewed for channel which is why we store the LastViewedAt internally (see #361 and #245).
Apologies @42wim