Make replay a service in preparation for consolidating with search & scrollback #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
replay-as-service
branch
2 times, most recently
from
b9de1aa to
fec77d7
Compare
hloeung
force-pushed
the
replay-as-service
branch
from
fec77d7 to
53ce647
Compare
|
Merging this created an unexpected problem for me: I cannot join private channels any more |
Is it because of this change or stock 0.28.0 per #578? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the replay code as is with minimal changes making it a service similar to
search&scrollback.This is in preparation for cleaning up and consolidating the code between the three to reduce duplicate code and so they're consistent. See also #553 for work on making search consistent.