Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for message attachments #575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for message attachments #575

wants to merge 1 commit into from

Conversation

hloeung
Copy link
Collaborator

@hloeung hloeung commented Feb 16, 2024

Fixes #574

@hloeung hloeung force-pushed the message-attachments branch from cfeafd5 to 1b8fb62 Compare February 16, 2024 08:32
@hloeung hloeung marked this pull request as draft February 27, 2024 20:05
@kot0dama
Copy link

Works for me, thanks!
But then on scrollback the messages still show up as empty.

@hloeung
Copy link
Collaborator Author

hloeung commented Apr 16, 2024

Works for me, thanks! But then on scrollback the messages still show up as empty.

Yeah, known. I'm hoping to get #554 landed moving things around making replay a service then I can update it to support message attachments as well.

@hloeung hloeung requested a review from 42wim June 6, 2024 21:38
@hloeung hloeung marked this pull request as ready for review June 6, 2024 21:38
NightTsarina added a commit to Tina-pm/matterircd that referenced this pull request Nov 17, 2024
@NightTsarina
Add support for message attachments (42wim#575)
5511184 
Merge 42wim#575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42wim 42wim Awaiting requested review from 42wim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for message attachments
2 participants
@hloeung @kot0dama