Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13 release, drop Scala 2.11 support #262

Closed
wants to merge 6 commits into from

Conversation

bilki
Copy link

@bilki bilki commented Aug 9, 2019

Well, I've tried to cross-build github4s with Scala 2.13, and after tuning a bit SBT files and bumping dependencies, this is the current state:

  • Macro paradise compiler plugin is no longer necessary for 2.13 (-Ymacro-annotations)
  • We are missing the following dependencies (I'm going to open issues there asking about their expected roadmap to 2.13)
    • org.scalamock#scalamock-scalatest-support_2.13;3.6.0
    • fr.hmil#roshttp_sjs0.6_2.13;2.2.4
  • Circe is dropping support for Scala 2.11 in 0.12 (and adding support for Scala 2.13), so we are forced to either drop Circe dependency or to drop Scala 2.11 support ourselves

I also bumped sbt-org-policies version to use 0.11.4, with @juanpedromoreno changes to exclude kind-projector from default settings, which was producing version problems as well.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to drop 2.11 👍

@bilki
Copy link
Author

bilki commented Aug 12, 2019

I bumped sbt-org-policies version, updated travis config file, and opened this PR for the last pending dependency that will allow us to build against 2.13:

hmil/RosHTTP#88

Scalamock wasn't a stopper after all, bumped to 4.3.0 and it works fine with 2.13.

@bilki
Copy link
Author

bilki commented Aug 12, 2019

By the way, compiling for 2.13 is issuing a ton of warnings about UTF-8 arrows, I will open another PR to migrate from those to plain two-character arrows.

Co-Authored-By: Juan Pedro Moreno <4879373+juanpedromoreno@users.noreply.github.com>
@juanpedromoreno
Copy link
Member

May I suggest removing the ScalaJS compatibility?

https://github.com/search?q=%22%25%25%25+github4s%22&type=Code

Unless my search is wrong, there are not many usages out there.

Thoughts?

@BenFradet
Copy link
Contributor

We can drop scalaz too 👍

@duanebester
Copy link
Contributor

@bilki all arrows have now been migrated to plain two-character arrows

@juanpedromoreno
Copy link
Member

Superseded by #311

@juanpedromoreno juanpedromoreno deleted the 261-cross-build-scala213 branch July 17, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants