Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Scala to 2.13 #53

Merged
merged 4 commits into from
Oct 4, 2019
Merged

Upgrade Scala to 2.13 #53

merged 4 commits into from
Oct 4, 2019

Conversation

lavrov
Copy link
Contributor

@lavrov lavrov commented Sep 12, 2019

No description provided.

@TimWSpence
Copy link
Owner

Hey @lavrov did you mean to mark this PR as a draft?

@lavrov
Copy link
Contributor Author

lavrov commented Sep 16, 2019

docs module doesn't compile because some dependencies are not published for 2.13 (e.g github4s). I could reorganize the build so that docs would not depend on scala version. Do you think it makes sense?

@TimWSpence
Copy link
Owner

Oh yes, I remember that now! I had a very quick look at supporting 2.13 and had the same issue. I think it's probably a bit dodgy to make the docs not depend on scala version, given that the docs should work for the supported scala version! Or maybe I've misunderstood your suggestion!

It looks like 2.13 support might be coming soon for Github4s so I think I'm happy to wait for that?

Out of curiousity: are you using this library for anything at the moment? Keen to hear feedback from any users! :)

@lavrov
Copy link
Contributor Author

lavrov commented Sep 16, 2019

Compiling and running tut samples in docs with all supported version of Scala makes sense. However it's unfortunate that github4s is a compile-time dependency of that module. Probably the issue with github4s will be resolved soon.

Out of curiousity: are you using this library for anything at the moment? Keen to hear feedback from any users! :)

There is quite trivial use here. I find the api quite expressive and intuitive. I especially like STM.check(...) which makes the whole difference compared to Ref or MVar.

@juanpedromoreno
Copy link

Just in case this helps, as mentioned here: 47degrees/github4s#261, if you have issues in the docs module, you could follow this path temporarily:

Present workaround is to exclude docs from aggregated build, and only run docs commands on scala <= 2.12

@lavrov lavrov marked this pull request as ready for review September 19, 2019 21:21
@lavrov
Copy link
Contributor Author

lavrov commented Sep 20, 2019

One test started failing after Scalacheck 1.14.1 upgrade. All tests pass on 1.14.0

@Jacke
Copy link

Jacke commented Sep 26, 2019

+++++++++=

@TimWSpence
Copy link
Owner

Sorry all, I've been a bit busy! Yes, I'm aware the tests have been failing 😭I'll fix that and then look into this. Would love to get 2.13 supported!

@TimWSpence
Copy link
Owner

Ok I've rolled back the scalatest version. @lavrov could you rebase your PR? Thanks very much! :)

@lavrov
Copy link
Contributor Author

lavrov commented Oct 4, 2019

@TimWSpence done! I have updated .travis as well.

@TimWSpence TimWSpence merged commit 2e2731e into TimWSpence:master Oct 4, 2019
@TimWSpence
Copy link
Owner

Awesome, thanks @lavrov! :) I'll try to make a new release this afternoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants