-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 2.13 release, drop Scala 2.11 support #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to drop 2.11 👍
I bumped Scalamock wasn't a stopper after all, bumped to 4.3.0 and it works fine with 2.13. |
By the way, compiling for 2.13 is issuing a ton of warnings about UTF-8 arrows, I will open another PR to migrate from those to plain two-character arrows. |
Co-Authored-By: Juan Pedro Moreno <4879373+juanpedromoreno@users.noreply.github.com>
May I suggest removing the ScalaJS compatibility? https://github.com/search?q=%22%25%25%25+github4s%22&type=Code Unless my search is wrong, there are not many usages out there. Thoughts? |
We can drop scalaz too 👍 |
@bilki all arrows have now been migrated to plain two-character arrows |
Superseded by #311 |
Well, I've tried to cross-build github4s with Scala 2.13, and after tuning a bit SBT files and bumping dependencies, this is the current state:
I also bumped
sbt-org-policies
version to use0.11.4
, with @juanpedromoreno changes to excludekind-projector
from default settings, which was producing version problems as well.