Doc: add an example for GitHub Actions #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvellido
approved these changes
May 11, 2020
|
Thanks @calvellido for the review 🙌 |
AdrianRaFo
reviewed
May 11, 2020
| @@ -10,6 +10,8 @@ permalink: gradle/ci/ | |||
| **Hood** gives you the ability to integrate the benchmark comparison into your `CI` | |||
| and integrate the result into a `Github` pull request. | |||
|
|
|||
| It provides `compareBenchmarksCI` Gradle task which compares 2 reports from a benchmark and then it creates a new comment with the comparison result in the pull request. For instance, [look at this comment](https://github.com/47degrees/helios/pull/137#issuecomment-597753181). If new commits are added to the same pull request, the comment will be updated with the new comparison result. | |||
There was a problem hiding this comment.
actually compare a benchmarks with a series of benchmarks no just 2
| @@ -10,6 +10,8 @@ permalink: gradle/ci/ | |||
| **Hood** gives you the ability to integrate the benchmark comparison into your `CI` | |||
| and integrate the result into a `Github` pull request. | |||
|
|
|||
| It provides `compareBenchmarksCI` Gradle task which compares 2 reports from a benchmark and then it creates a new comment with the comparison result in the pull request. For instance, [look at this comment](https://github.com/47degrees/helios/pull/137#issuecomment-597753181). If new commits are added to the same pull request, the comment will be updated with the new comparison result. | |||
There was a problem hiding this comment.
it also adds an status to the pull request
|
Apparently my review comments weren't posted |
Don't worry, I'll create another PR to fix it 🙌 Thanks for the review @AdrianRaFo !! |
rachelcarmena
added a commit
that referenced
this pull request
May 11, 2020
rachelcarmena
added a commit
that referenced
this pull request
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some missing documentation after integrating Hood into Arrow Fx library.