Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Solve #76. Add benchmark comparison #159

Merged
merged 2 commits into from
May 11, 2020
Merged

Conversation

rachelcarmena
Copy link
Member

@rachelcarmena rachelcarmena commented May 8, 2020

This PR adds benchmark comparison via Hood so a comment with the result will be added in every pull request on this repository.

See the comment below as an example.

That comment will be updated with new commits:

Screenshot from 2020-05-08 19-27-56

In this case there isn't difference between values because this pull request is just adding the configuration and it's not changing Arrow Fx library.

It only shows Concurrentqueue because it's the only benchmark included:

jmh {
    include = [
            'arrow.benchmarks.Queue'
    ]
    ...
}

For instance, for this configuration:

jmh {
    include = [
            'arrow.benchmarks.Async',
            'arrow.benchmarks.Queue'
    ]
    ...
}

it would appear data for:

  • Async.catsIO
  • Async.io
  • Async.scalazZIO
  • Queue.concurrentQueue

Default threshold is being used. However, it can be changed in compareBenchmarksCI task configuration: https://47degrees.github.io/hood/gradle/ci/

For the rest of open pull requests, the comment with the results will appear when merging this pull request and then updating those pull requests with master branch.

Thanks to @AdrianRaFo for providing me the guide about it 🙌

@github-actions
Copy link

github-actions bot commented May 8, 2020

Hood benchmark comparison:
✔️ Concurrentqueue (Threshold: 11.35485483248408)

Benchmark Value
master-branch 242.3360692865897
pull-request 250.00612096262103

@rachelcarmena rachelcarmena linked an issue May 8, 2020 that may be closed by this pull request
@rachelcarmena rachelcarmena marked this pull request as ready for review May 8, 2020 17:25
@rachelcarmena rachelcarmena marked this pull request as draft May 8, 2020 17:38
@rachelcarmena rachelcarmena marked this pull request as ready for review May 8, 2020 17:39
Copy link
Member

@aballano aballano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! 👍

@rachelcarmena rachelcarmena merged commit deca849 into master May 11, 2020
@rachelcarmena
Copy link
Member Author

Thanks @aballano 🙌

@rachelcarmena rachelcarmena deleted the add-benchmarks-comparison branch May 11, 2020 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include benchmarks on pull requests
2 participants