Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Melodic] release fixes #209

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Conversation

@fmessmer fmessmer changed the title release fixes [Melodic] release fixes Aug 9, 2019
@fmessmer
Copy link
Contributor Author

fmessmer commented Aug 9, 2019

@ipa-fez
Copy link

ipa-fez commented Aug 9, 2019

The problem seems to be that boost shared_ptrs and std shared ptrs are being mixed. we're trying to cast the geometry from a std shared ptr of one type to a boost shared_ptr of another type, but we can only cast it to a std shared_ptr of a different type.

@ipa-fez
Copy link

ipa-fez commented Aug 9, 2019

More concrete: PtrGeometry_t seems to be a std::shared_ptr for some reason while everything else is boost::shared_ptr

@fmessmer
Copy link
Contributor Author

fmessmer commented Aug 9, 2019

yap, in kinetic, urdf is using boost::shared while in melodic urdf uses std::shared

I'm resolving this by using a new melodic_dev branch...it's cleaner than a macro...
I'll create the branch as soon as #210 is merged

@fmessmer fmessmer changed the base branch from kinetic_dev to melodic_dev August 9, 2019 10:22
@fmessmer fmessmer merged commit 6d1a917 into 4am-robotics:melodic_dev Aug 9, 2019
@fmessmer fmessmer deleted the release_fixes branch August 9, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants