fix(SPV-1283): use proper upsertcontact command field for a path param #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
contacts
feature to improve the handling of paymail addresses. The most important changes include the addition of a new field for contact paymail and updates to the relevant methods and tests to reflect this change.Handling of Paymail Addresses:
commands/contacts.go
: Added a new fieldContactPaymail
to theUpsertContact
struct to separately store the paymail address of the contact being added or updated. Updated the field namePaymail
toRequesterPaymail
for clarity.examples/contact_upsert/contact_upsert.go
: Updated the example to use the newContactPaymail
field and provided comments for the optionalRequesterPaymail
field.internal/api/v1/user/contacts/contacts_api.go
: Modified theUpsertContact
method to use the newContactPaymail
field when making the HTTP PUT request.internal/api/v1/user/contacts/contacts_api_test.go
: Updated the test for theUpsertContact
method to use theRequesterPaymail
field.Pull Request Checklist