Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SPV-1283): use proper upsertcontact command field for a path param #41

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

wregulski
Copy link

@wregulski wregulski commented Dec 9, 2024

This pull request includes changes to the contacts feature to improve the handling of paymail addresses. The most important changes include the addition of a new field for contact paymail and updates to the relevant methods and tests to reflect this change.

Handling of Paymail Addresses:

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@wregulski wregulski added the bug label Dec 9, 2024
@wregulski wregulski self-assigned this Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@wregulski wregulski merged commit 285311f into main Dec 10, 2024
8 checks passed
@wregulski wregulski deleted the feat/spv-1283 branch December 10, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants