fix(SPV-1283): use proper upsertcontact command field for a path param

commands/contacts.go

@@ -2,9 +2,10 @@ package commands
 
 // UpsertContact holds the necessary arguments for adding or updating a user's contact information.
 type UpsertContact struct {
-	FullName string         `json:"fullName"`         // The full name of the user.
-	Metadata map[string]any `json:"metadata"`         // Metadata associated with the contact.
-	Paymail  string         `json:"requesterPaymail"` // Paymail address of the user, which is used for secure and simplified payment transfers.
+	ContactPaymail   string         `json:"-"`                // Paymail address of the new/updating contact.
+	FullName         string         `json:"fullName"`         // The full name of the user.
+	Metadata         map[string]any `json:"metadata"`         // Metadata associated with the contact.
+	RequesterPaymail string         `json:"requesterPaymail"` // RequesterPaymail address of the user, which is used for secure and simplified payment transfers.
 }
 
 // UpdateContact represents the arguments defined for updating a user's contact information.

examples/contact_upsert/contact_upsert.go

@@ -17,17 +17,20 @@ func main() {
 		log.Fatal(err)
 	}
 
-	paymail := "john.doe@example.com"
+	contactPaymail := "john.doe@example.com"
 	contact, err := usersAPI.UpsertContact(context.Background(), commands.UpsertContact{
-		FullName: "John Doe",
+		ContactPaymail: contactPaymail,
+		FullName:       "John Doe",
 		Metadata: map[string]any{
 			"key": "value",
 		},
-		Paymail: paymail,
+		// Optional field representing the paymail address of the user who is creating the contact.
+		// It is required in case if user has multiple paymail addresses associated with single xPub.
+		//RequesterPaymail: "",
 	})
 	if err != nil {
 		log.Fatal(err)
 	}
 
-	exampleutil.Print(fmt.Sprintf("[HTTP PUT] Upsert contact - api/v1/contacts/%s", paymail), contact)
+	exampleutil.Print(fmt.Sprintf("[HTTP PUT] Upsert contact - api/v1/contacts/%s", contactPaymail), contact)
 }

internal/api/v1/user/contacts/contacts_api.go

@@ -79,7 +79,7 @@ func (a *API) UpsertContact(ctx context.Context, cmd commands.UpsertContact) (*r
 		SetBody(cmd).
 		SetContext(ctx).
 		SetResult(&result).
-		Put(a.url.JoinPath(cmd.Paymail).String())
+		Put(a.url.JoinPath(cmd.ContactPaymail).String())
 	if err != nil {
 		return nil, fmt.Errorf("HTTP response failure: %w", err)
 	}

internal/api/v1/user/contacts/contacts_api_test.go

@@ -121,9 +121,9 @@ func TestContactsAPI_UpsertContact(t *testing.T) {
 
 			// when:
 			got, err := wallet.UpsertContact(context.Background(), commands.UpsertContact{
-				FullName: "John Doe",
-				Metadata: map[string]any{"example_key": "example_val"},
-				Paymail:  paymail,
+				ContactPaymail: paymail,
+				FullName:       "John Doe",
+				Metadata:       map[string]any{"example_key": "example_val"},
 			})
 
 			// then: