Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContentType to graphql.Upload #1074

Merged
merged 3 commits into from
Mar 4, 2020

Conversation

yudppp
Copy link
Contributor

@yudppp yudppp commented Feb 28, 2020

Hi, I want to use Upload file Content-Type.
So I added this code.

Please check:)

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

ref: #1073

@coveralls
Copy link

coveralls commented Feb 28, 2020

Coverage Status

Coverage decreased (-0.6%) to 65.659% when pulling 8d540db on yudppp:feature/add_contenttype_for_upload into b165568 on 99designs:master.

@yudppp yudppp force-pushed the feature/add_contenttype_for_upload branch from ca8e60d to cff73f7 Compare February 28, 2020 10:32
@vektah
Copy link
Collaborator

vektah commented Mar 1, 2020

Needs a test and ideally updates to the documentation describing how it would be used.

@yudppp yudppp force-pushed the feature/add_contenttype_for_upload branch from 66888f9 to 8d540db Compare March 2, 2020 14:03
@yudppp
Copy link
Contributor Author

yudppp commented Mar 2, 2020

Hi @vektah
I understand it. I wrote document and test code.

@vektah
Copy link
Collaborator

vektah commented Mar 4, 2020

Awesome, thanks for the PR.

@vektah vektah merged commit 587bc81 into 99designs:master Mar 4, 2020
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
…_for_upload

Add ContentType to graphql.Upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants