Add cutomization error for MaxUploadSize #1093
Conversation
keisku
changed the title
|
|
||
| srv := handler.New(fileupload.NewExecutableSchema(fileupload.Config{Resolvers: resolver})) | ||
|
|
||
| srv.AddTransport(transport.MultipartForm{ |
There was a problem hiding this comment.
this example is supposed to show how to configure the transport directly, not use the defaults
There was a problem hiding this comment.
I could not start example app on master without this changes.
What I did
git checkout master- go run
❯ go run example/fileupload/server/server.go
2020/04/22 13:20:32 connect to http://localhost:8087/ for GraphQL playground
- checking this error on developer tool on Google Chrome.
this example is supposed to show how to configure the transport directly, not use the defaults
could you check this commit?
| ID: i + 1, | ||
| Name: req.File.Filename, | ||
| Content: string(content), | ||
| ContentType: req.File.ContentType, |
There was a problem hiding this comment.
these changes seem unrelated?
There was a problem hiding this comment.
According to #1074 changes, I think it is related.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing this as I don't think error messages need to be customized. If I ship this one, then theres another 100 prs full of similar requests. If you think the default isn't good, propose an update |
Hi, I want to customize error even if using
MaxUploadSize, so I added this file.And I fixed an error when I stated the example app.
This PullRequest is related to #1089 (comment).
I have: