Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2190 - don't use backslash for "embed" paths on windows #2191

Merged
merged 1 commit into from
May 24, 2022
Merged

fix #2190 - don't use backslash for "embed" paths on windows #2191

merged 1 commit into from
May 24, 2022

Conversation

vikstrous
Copy link
Contributor

See #2190
I can't test this change. CI testing on windows would be helpful if there's an easy way to set that up: #2189

@vikstrous vikstrous marked this pull request as ready for review May 23, 2022 21:18
@vikstrous vikstrous mentioned this pull request May 23, 2022
Merged
1 task
@vikstrous vikstrous force-pushed the use-path branch 2 times, most recently from 9a9b0ac to f63aef7 Compare May 23, 2022 21:31
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 74.944% when pulling 04514a5 on vikstrous:use-path into 0cce554 on 99designs:master.

@StevenACoffman StevenACoffman merged commit 41daa5d into 99designs:master May 24, 2022
@mtibben mtibben mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikstrous @coveralls @StevenACoffman