Run CI tests on windows #2199
Merged
Run CI tests on windows #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's so cool! I didn't expect the script to just work on windows. I thought that windows's CLI is totally different. Sorry for my lack of windows knowledge. If I knew it was this easy, I might have done this with my original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few PRs (#2197 #2191) go through mentioning windows compatibility.
This adds Windows to Github Actions so that we can ensure gqlgen is working on Windows and write tests specifically targeted at windows if required.
@vikstrous @frederikhors can you ensure that your fixes have appropriate tests?
Fixes #2189