Update gqlparser to v2.5.0 #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Coffman <steve@khanacademy.org>
StevenACoffman
requested review from
a8m,
frederikhors,
lwc,
MichaelJCompton and
mtibben
StevenACoffman
added a commit
that referenced
this pull request
Sep 13, 2022
Signed-off-by: Steve Coffman <steve@khanacademy.org>
StevenACoffman
added a commit
that referenced
this pull request
Sep 13, 2022
* nil check error before cast from #2341 Signed-off-by: Steve Coffman <steve@khanacademy.org> * Improve errcode.Set safety Signed-off-by: Steve Coffman <steve@khanacademy.org> Signed-off-by: Steve Coffman <steve@khanacademy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per vektah/gqlparser#234 and vektah/gqlparser#99 and vektah/gqlparser#100
In gqlparser all methods which were returning an error were using the explicit struct type (e.g. *gqlerror.Error or gqlerror.List). As long as you used the explicit types everything was fine, but as soon as you converted them to the
errorinterface type, nil checks would fail. As a result, gqlparser recently was changed to returnerrorinterface, so we need to perform a type assertion to convert it to*gqlerror.Errorin some places. It seems to me like this is a fairly minor change for those using gqlgen directly. What do you think?The current gqlgen release version is v0.17.15. If this is deemed enough of a breaking change, we can release this as v0.18.0,
otherwise, I will proceed with v0.17.16
Signed-off-by: Steve Coffman steve@khanacademy.org