Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use error interface instead of gqlerror as return type #100

Closed
wants to merge 3 commits into from
Closed

use error interface instead of gqlerror as return type #100

wants to merge 3 commits into from

Conversation

robojones
Copy link

fix #99

@coveralls
Copy link

coveralls commented May 15, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 91.346% when pulling 4b22b3e on robojones:errors into 05741cd on vektah:master.

vektah
vektah reviewed May 16, 2019
View reviewed changes
parser/query_test.go Outdated Show resolved Hide resolved
@robojones
Copy link
Author

I'm currently looking through the code, trying to decide at which point I should stop returning gqlerror.* and start returning error.
Currently I converted the public methods from these packages:

  • main
  • parser
  • validator

@robojones robojones closed this Aug 7, 2019
@schafle schafle mentioned this pull request Aug 25, 2022
Merged
@StevenACoffman StevenACoffman mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vektah vektah vektah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use error instead of *gqlerror.Error
3 participants
@robojones @coveralls @vektah