Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: Unalias before lookup type #3247

Merged
merged 1 commit into from
Sep 5, 2024
Merged

codegen: Unalias before lookup type #3247

merged 1 commit into from
Sep 5, 2024

Conversation

giautm
Copy link
Contributor

@giautm giautm commented Sep 5, 2024 •
edited
Loading

This ensure the result always the same for single type.

@giautm giautm changed the title g/go 1.23 alias codegen: Unalias before lookup type Sep 5, 2024
@coveralls
Copy link

Coverage Status

coverage: 56.648% (-0.02%) from 56.671%
when pulling 613c9f8 on giautm:g/go-1.23-alias
into ab1781b on 99designs:master.

@giautm giautm marked this pull request as ready for review September 5, 2024 11:27
@giautm giautm changed the title codegen: Unalias before lookup type codegen: Unalias before lookup type Sep 5, 2024
@giautm
Copy link
Contributor Author

giautm commented Sep 5, 2024

cc @StevenACoffman , @a8m

@StevenACoffman StevenACoffman merged commit 4c4be0a into 99designs:master Sep 5, 2024
16 of 17 checks passed
@StevenACoffman
Copy link
Collaborator

Thanks very much! I really appreciate all of your contributions.

giautm added a commit to giautm/gqlgen that referenced this pull request Sep 5, 2024
@giautm
codegen: Revert Unalias before lookup type (99designs#3247)
0d5816f 
This reverts commit 4c4be0a.
@giautm giautm mentioned this pull request Sep 5, 2024
Merged
a8m pushed a commit that referenced this pull request Sep 5, 2024
@giautm
internal/code: Unalias element of pointer (#3250)
86ac6b3 
* codegen: Revert Unalias before lookup type (#3247)

This reverts commit 4c4be0a.

* code: `Unalias` element of pointer

* chore: added comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giautm @coveralls @StevenACoffman