Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/code: Unalias element of pointer #3250

Merged
merged 3 commits into from
Sep 5, 2024
Merged

internal/code: Unalias element of pointer #3250

merged 3 commits into from
Sep 5, 2024

Conversation

giautm
Copy link
Contributor

@giautm giautm commented Sep 5, 2024 •
edited
Loading

No description provided.

@coveralls
Copy link

coveralls commented Sep 5, 2024 •
edited
Loading

Coverage Status

coverage: 56.699% (+0.02%) from 56.679%
when pulling 98de809 on giautm:g/go-1.23-alias
into 4c4be0a on 99designs:master.

@giautm
Copy link
Contributor Author

giautm commented Sep 5, 2024

Sorry you guys, I revert the last changes and fix the case with Pointer.

cc: @a8m, @StevenACoffman

@a8m a8m merged commit 86ac6b3 into 99designs:master Sep 5, 2024
15 of 17 checks passed
@giautm giautm deleted the g/go-1.23-alias branch September 5, 2024 17:42
@StevenACoffman
Copy link
Collaborator

Hey, thanks for the fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giautm @coveralls @StevenACoffman @a8m