Fix failure to register background callback #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljkor
changed the title
ABausG
reviewed
Jul 20, 2021
There was a problem hiding this comment.
Thanks for this. Have you tried adding a Integration Test (you can find them here: https://github.com/ABausG/home_widget/blob/main/example/integration_test/android_test.dart)
| @@ -101,8 +101,8 @@ class HomeWidgetPlugin : FlutterPlugin, MethodCallHandler, ActivityAware, | |||
| } | |||
| } | |||
| "registerBackgroundCallback" -> { | |||
| val dispatcher = (call.arguments as Iterable<*>).toList()[0] as Long | |||
| val callback = (call.arguments as Iterable<*>).toList()[1] as Long | |||
| val dispatcher = (call.arguments as Iterable<*>).toList()[0].toString().toLong() | |||
There was a problem hiding this comment.
Converting this toString feels really hacky. I guess it would also work if you cast the argument with as Number and call toLong on that
There was a problem hiding this comment.
Yes, I agree this is a less hacky solution, I implemented it and it works this way too. I fixed to casting as Number and then calling toLong()
ABausG
reviewed
Jul 20, 2021
android/src/main/kotlin/es/antonborri/home_widget/HomeWidgetPlugin.kt
Outdated
Show resolved
Hide resolved
…ugin.kt Co-authored-by: Anton Borries <anton.borries@gmail.com>
|
Hi @ABausG. I am also receiving this error. Can you please marge this pull request?
|
|
Any update on this? I am facing the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this fixes the casting issue that occurs when trying to register background callback to register clicks on parts of a home widget.
Best regards,
Aljosa